JDK 9 RFR of JDK-8068693: (ch) test java/nio/channels/AsyncCloseAndInterrupt.java failing

[Brian Burkhalter]

Hi Hamlin,

I am a bit confused about some things here. Firstly the issue is filed as the test failing on the Windows OS only, but some comments indicate that failures have been observed on Linux as well.

Secondly, the change in the backlog setting occurs in the initRefuser() method which is invoked only if TestUtil.onWindows() is false, i.e., the test is not being run on Windows. So one would think that the backlog change would have no effect on Windows.

Thirdly, if the test is being run with assertions enabled, then it appears that line 517 would throw an AssertionError on Windows and your changes at lines 523, 532, and 544-547 would never be executed.

Hopefully I am just misinterpreting something here.

Thanks,

Brian

On Mar 4, 2016, at 2:36 AM, Hamlin Li <huaming.li at oracle.com> wrote:

> Please review the patch for test java/nio/channels/AsyncCloseAndInterrupt.java
> 
> It's a test issue. The issue can be reproduced locally within 50 rounds of run.
> Root cause: even if server's connection backlog seems to be saturated sometime, subsequent connections may still success.
> Suggested Fix: Pass in parameter backlog as 1 when ServerSocket calls bind to make the socket server's backlog queue as short as possible. In pumpRefuser, try to connect to refuser server as quick as possible. The fix run successfully for 300 rounds of run locally, pass JPRT test.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8068693
> webrev: http://cr.openjdk.java.net/~mli/8068693/webrev.00/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160309/b12b8300/attachment-0001.html>