JDK 9 RFR of JDK-8151582: (ch) test java/nio/channels/AsyncCloseAndInterrupt.java failing due to "Connection succeeded"
Hamlin Li
huaming.li at oracle.com
Fri Mar 18 03:59:39 UTC 2016
On 2016/3/15 7:29, Brian Burkhalter wrote:
> Hi Hamlin,
>
> On Mar 14, 2016, at 4:26 PM, Hamlin Li <huaming.li at oracle.com
> <mailto:huaming.li at oracle.com>> wrote:
>
>> Please let me clarify it: Even with backlog set to 1, there will be
>> more than 1 successful connections on some platforms, for example
>> linux, and it will grow very slowly, the test results on my local
>> verify this. And, even if on some other platforms there is only 1
>> connection totally in the complete and incomplete queues, it will not
>> do harm to test, because what we want refuser server to do is to
>> reject connections from any clients except the earliest connection[s]
>> from pump thread before refuser server is saturated. I think it's
>> better to set backlog of refuser server as 1, so we can make
>> refuser's complete and incomplete queues saturated as quickly as
>> possible by pump thread, and it will be more possible for pump thread
>> to make sure saturate the queues.
>> Not sure if clarification above is clear enough, please let me know
>> your further concerns. :-)
>
> OK, now I understand it better. I am OK with the patch but you will
> still need another +1 from an actual Reviewer.
Would some reviewer be available to review the patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8151582
webrev: http://cr.openjdk.java.net/~mli/8151582/webrev.00
Thank you
-Hamlin
>
> Thanks,
>
> Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160318/0ca92fa8/attachment-0001.html>
More information about the nio-dev
mailing list