JDK 9 RFR of JDK-8151582: (ch) test java/nio/channels/AsyncCloseAndInterrupt.java failing due to "Connection succeeded"

[Alan Bateman]

On 18/03/2016 03:59, Hamlin Li wrote:
>
>
> Would some reviewer be available to review the patch?
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8151582
> webrev: http://cr.openjdk.java.net/~mli/8151582/webrev.00
This looks okay although I can't help thinking that we are trying to 
test a scenario that is impossible to test reliably.

A minor point but adding ", Wait successfully" to the trace messages 
makes for unusual trace messages like:

   finishConnect wait for pumping refuser ..., Wait successfully

If we s/wait/waiting/ and have the suffix be "done" then it would be a 
bit cleaner.

Another minor point is that you can use refuser.bind(wildcardAddress, 
1), no need for the socket adapter.

I'll these are minor comments then I'll update your patch and get this 
into jdk9/dev.

-Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160320/422f2566/attachment.html>