JDK 9 RFR of JDK-8151582: (ch) test java/nio/channels/AsyncCloseAndInterrupt.java failing due to "Connection succeeded"

[Hamlin Li]

Hi Alan,

Just have 2 questions.
   1. Would you mind suggest if it's necessary to back port this fix to 
earlier versions? If positive, which verions?
   2. I isolated this issue from JDK-8068693, as I think these 2 issue 
are totally different, and I think JDK-8068693 might be due to an 
environment issue, and it last occurred at at 2015-05-13. Could I 
suggest to close JDK-8068693?

Thank you
-Hamlin

On 2016/3/20 15:45, Alan Bateman wrote:
> On 18/03/2016 03:59, Hamlin Li wrote:
>>
>>
>> Would some reviewer be available to review the patch?
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8151582
>> webrev: http://cr.openjdk.java.net/~mli/8151582/webrev.00
> This looks okay although I can't help thinking that we are trying to 
> test a scenario that is impossible to test reliably.
>
> A minor point but adding ", Wait successfully" to the trace messages 
> makes for unusual trace messages like:
>
>   finishConnect wait for pumping refuser ..., Wait successfully
>
> If we s/wait/waiting/ and have the suffix be "done" then it would be a 
> bit cleaner.
>
> Another minor point is that you can use refuser.bind(wildcardAddress, 
> 1), no need for the socket adapter.
>
> I'll these are minor comments then I'll update your patch and get this 
> into jdk9/dev.
>
> -Alan.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160320/c9333d44/attachment-0001.html>