RFR(s): 8169710: com/sun/nio/sctp tests has undeclared dependency on jdk.sctp module

Sergei Kovalev sergei.kovalev at oracle.com
Tue Nov 15 11:59:34 UTC 2016


Hi Daniel,

Good catch. Thank you. I've wrongly thought that TEST.properties affects 
only test of single level and not affects sub-folders. I checked your 
recommendation and found that it also works fine.

See web review: http://cr.openjdk.java.net/~skovalev/8169710/webrev.01/

-- 
With best regards,
Sergei

15.11.16 14:26, Daniel Fuchs wrote:
> Hi Sergey,
>
> I'm not an expert in TEST.properties but this looks bizarre
> to me. Why not simply put a single TEST.properties file in
> com/sun/nio/sctp?
>
> best regards
>
> -- daniel
>
> On 15/11/16 11:21, Sergei Kovalev wrote:
>> Hello team,
>>
>> Please review very small fix for test suite from com/sun/nio/sctp 
>> folder.
>>
>> BugID: https://bugs.openjdk.java.net/browse/JDK-8169710
>> Web review: http://cr.openjdk.java.net/~skovalev/8169710/webrev.00/
>>
>> Issue: The tests failing in case of usage "--limit modules java.base"
>> command line options.
>> Solution: add module declaration for tests. Because all tests from the
>> appropriate folders are affected it is better to add "TEST.properties"
>> file that contains dependency declaration to each folder. In this case
>> we have no need to modify each test separately.


More information about the nio-dev mailing list