From brian.burkhalter at oracle.com  Mon Apr  3 18:37:56 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Mon, 3 Apr 2017 11:37:56 -0700
Subject: JDK 9 RFR of 8177984: (ch)
 java/nio/channels/SocketChannel/VectorIO.java should use RandomFactory
Message-ID: <FEE12AC9-53FC-4362-9EE5-BC12FC260341@oracle.com>

https://bugs.openjdk.java.net/browse/JDK-8177984
http://cr.openjdk.java.net/~bpb/8177984/webrev.00/

Replace direct construction of Random with use of RandomFactory.

Thanks,

Brian

From christoph.langer at sap.com  Tue Apr  4 04:54:48 2017
From: christoph.langer at sap.com (Langer, Christoph)
Date: Tue, 4 Apr 2017 04:54:48 +0000
Subject: JDK 9 RFR of 8177984: (ch)
 java/nio/channels/SocketChannel/VectorIO.java should use RandomFactory
In-Reply-To: <FEE12AC9-53FC-4362-9EE5-BC12FC260341@oracle.com>
References: <FEE12AC9-53FC-4362-9EE5-BC12FC260341@oracle.com>
Message-ID: <5b04b25fb33e45b592944413c6fa287d@sap.com>

Hi Brian,

this looks good.

Best regards
Christoph

> -----Original Message-----
> From: nio-dev [mailto:nio-dev-bounces at openjdk.java.net] On Behalf Of
> Brian Burkhalter
> Sent: Montag, 3. April 2017 20:38
> To: nio-dev <nio-dev at openjdk.java.net>
> Subject: JDK 9 RFR of 8177984: (ch)
> java/nio/channels/SocketChannel/VectorIO.java should use RandomFactory
> 
> https://bugs.openjdk.java.net/browse/JDK-8177984
> http://cr.openjdk.java.net/~bpb/8177984/webrev.00/
> 
> Replace direct construction of Random with use of RandomFactory.
> 
> Thanks,
> 
> Brian

From chris.hegarty at oracle.com  Tue Apr  4 07:58:17 2017
From: chris.hegarty at oracle.com (Chris Hegarty)
Date: Tue, 4 Apr 2017 08:58:17 +0100
Subject: JDK 9 RFR of 8177984: (ch)
 java/nio/channels/SocketChannel/VectorIO.java should use RandomFactory
In-Reply-To: <FEE12AC9-53FC-4362-9EE5-BC12FC260341@oracle.com>
References: <FEE12AC9-53FC-4362-9EE5-BC12FC260341@oracle.com>
Message-ID: <C41B9AAF-2231-43FE-9AB7-EB6C3A981708@oracle.com>


> On 3 Apr 2017, at 19:37, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> https://bugs.openjdk.java.net/browse/JDK-8177984
> http://cr.openjdk.java.net/~bpb/8177984/webrev.00/

Looks fine Brian.

-Chris.

From brian.burkhalter at oracle.com  Tue Apr  4 23:00:26 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Tue, 4 Apr 2017 16:00:26 -0700
Subject: JDK 9 RFR of 8178074: (ch)
 java/nio/channels/etc/AdaptorCloseAndInterrupt.java: add instrumentation
Message-ID: <3DD04A58-6A70-4C69-B51C-C16FA245701D@oracle.com>

Please review this test-only change at your convenience.

Issue:	https://bugs.openjdk.java.net/browse/JDK-8178074
Patch:	http://cr.openjdk.java.net/~bpb/8178074/webrev.00/

The purpose of this change is to add output of certain information which might be of use in analyzing several different intermittent failures observed for this test [1, 2, 3]. The various failure modes are outlined in [4].

Thanks,

Brian

[1] https://bugs.openjdk.java.net/browse/JDK-8136899
[2] https://bugs.openjdk.java.net/browse/JDK-8150811
[3] https://bugs.openjdk.java.net/browse/JDK-8177853
[4] https://bugs.openjdk.java.net/browse/JDK-8136899?focusedCommentId=14066117&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14066117

From brian.burkhalter at oracle.com  Thu Apr  6 23:54:56 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Thu, 6 Apr 2017 16:54:56 -0700
Subject: Fwd: JDK 9 RFR of 8178074: (ch)
 java/nio/channels/etc/AdaptorCloseAndInterrupt.java: add instrumentation
References: <3DD04A58-6A70-4C69-B51C-C16FA245701D@oracle.com>
Message-ID: <D123621D-68E3-46E7-8E85-C404F29A5721@oracle.com>

Ping!

Begin forwarded message:

> From: Brian Burkhalter <brian.burkhalter at oracle.com>
> Subject: JDK 9 RFR of 8178074: (ch) java/nio/channels/etc/AdaptorCloseAndInterrupt.java: add instrumentation
> Date: April 4, 2017 at 4:00:26 PM PDT
> To: nio-dev <nio-dev at openjdk.java.net>
> 
> Please review this test-only change at your convenience.
> 
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8178074
> Patch:	http://cr.openjdk.java.net/~bpb/8178074/webrev.00/
> 
> The purpose of this change is to add output of certain information which might be of use in analyzing several different intermittent failures observed for this test [1, 2, 3]. The various failure modes are outlined in [4].
> 
> Thanks,
> 
> Brian
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8136899
> [2] https://bugs.openjdk.java.net/browse/JDK-8150811
> [3] https://bugs.openjdk.java.net/browse/JDK-8177853
> [4] https://bugs.openjdk.java.net/browse/JDK-8136899?focusedCommentId=14066117&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14066117

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170406/02b53dec/attachment-0001.html>

From chris.hegarty at oracle.com  Fri Apr  7 13:34:03 2017
From: chris.hegarty at oracle.com (Chris Hegarty)
Date: Fri, 7 Apr 2017 14:34:03 +0100
Subject: Fwd: JDK 9 RFR of 8178074: (ch)
 java/nio/channels/etc/AdaptorCloseAndInterrupt.java: add instrumentation
In-Reply-To: <D123621D-68E3-46E7-8E85-C404F29A5721@oracle.com>
References: <3DD04A58-6A70-4C69-B51C-C16FA245701D@oracle.com>
 <D123621D-68E3-46E7-8E85-C404F29A5721@oracle.com>
Message-ID: <edf09e80-d1ae-8dc7-53b2-3311a8aae052@oracle.com>

Seems ok Brian.

-Chris.

On 07/04/17 00:54, Brian Burkhalter wrote:
> Ping!
>
> Begin forwarded message:
>
>> *From: *Brian Burkhalter <brian.burkhalter at oracle.com
>> <mailto:brian.burkhalter at oracle.com>>
>> *Subject: **JDK 9 RFR of 8178074: (ch)
>> java/nio/channels/etc/AdaptorCloseAndInterrupt.java: add instrumentation*
>> *Date: *April 4, 2017 at 4:00:26 PM PDT
>> *To: *nio-dev <nio-dev at openjdk.java.net <mailto:nio-dev at openjdk.java.net>>
>>
>> Please review this test-only change at your convenience.
>>
>> Issue:https://bugs.openjdk.java.net/browse/JDK-8178074
>> Patch:http://cr.openjdk.java.net/~bpb/8178074/webrev.00/
>>
>> The purpose of this change is to add output of certain information
>> which might be of use in analyzing several different intermittent
>> failures observed for this test [1, 2, 3]. The various failure modes
>> are outlined in [4].
>>
>> Thanks,
>>
>> Brian
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8136899
>> [2] https://bugs.openjdk.java.net/browse/JDK-8150811
>> [3] https://bugs.openjdk.java.net/browse/JDK-8177853
>> [4]
>> https://bugs.openjdk.java.net/browse/JDK-8136899?focusedCommentId=14066117&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14066117
>

From brian.burkhalter at oracle.com  Fri Apr 14 20:19:42 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Fri, 14 Apr 2017 13:19:42 -0700
Subject: JDK 10 RFR of 8178783: Java_sun_nio_ch_EPoll_close0 definition,
 but no sun.nio.ch.EPoll.close0 declaration.
Message-ID: <B409B8DD-6726-4749-9271-EFD0CAE17289@oracle.com>

This eliminates an unused method only.

https://bugs.openjdk.java.net/browse/JDK-8178783

Thanks,

Brian

[1] diff

--- a/src/java.base/linux/native/libnio/ch/EPoll.c
+++ b/src/java.base/linux/native/libnio/ch/EPoll.c
@@ -95,9 +95,3 @@
     }
     return res;
 }
-
-JNIEXPORT void JNICALL
-Java_sun_nio_ch_EPoll_close0(JNIEnv *env, jclass c, jint epfd) {
-    int res;
-    RESTARTABLE(close(epfd), res);
-}

From Roger.Riggs at Oracle.com  Fri Apr 14 20:21:45 2017
From: Roger.Riggs at Oracle.com (Roger Riggs)
Date: Fri, 14 Apr 2017 16:21:45 -0400
Subject: JDK 10 RFR of 8178783: Java_sun_nio_ch_EPoll_close0 definition,
 but no sun.nio.ch.EPoll.close0 declaration.
In-Reply-To: <B409B8DD-6726-4749-9271-EFD0CAE17289@oracle.com>
References: <B409B8DD-6726-4749-9271-EFD0CAE17289@oracle.com>
Message-ID: <124aea61-1cae-add7-61a5-b516c7412de0@Oracle.com>

+1

Roger


On 4/14/2017 4:19 PM, Brian Burkhalter wrote:
> This eliminates an unused method only.
>
> https://bugs.openjdk.java.net/browse/JDK-8178783
>
> Thanks,
>
> Brian
>
> [1] diff
>
> --- a/src/java.base/linux/native/libnio/ch/EPoll.c
> +++ b/src/java.base/linux/native/libnio/ch/EPoll.c
> @@ -95,9 +95,3 @@
>       }
>       return res;
>   }
> -
> -JNIEXPORT void JNICALL
> -Java_sun_nio_ch_EPoll_close0(JNIEnv *env, jclass c, jint epfd) {
> -    int res;
> -    RESTARTABLE(close(epfd), res);
> -}


From chris.hegarty at oracle.com  Fri Apr 14 20:58:48 2017
From: chris.hegarty at oracle.com (Chris Hegarty)
Date: Fri, 14 Apr 2017 21:58:48 +0100
Subject: JDK 10 RFR of 8178783: Java_sun_nio_ch_EPoll_close0 definition,
 but no sun.nio.ch.EPoll.close0 declaration.
In-Reply-To: <B409B8DD-6726-4749-9271-EFD0CAE17289@oracle.com>
References: <B409B8DD-6726-4749-9271-EFD0CAE17289@oracle.com>
Message-ID: <03FD0FB2-59FA-4017-9242-326C2B5C0842@oracle.com>

Looks good Brian.

-Chris

> On 14 Apr 2017, at 21:19, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> This eliminates an unused method only.
> 
> https://bugs.openjdk.java.net/browse/JDK-8178783
> 
> Thanks,
> 
> Brian
> 
> [1] diff
> 
> --- a/src/java.base/linux/native/libnio/ch/EPoll.c
> +++ b/src/java.base/linux/native/libnio/ch/EPoll.c
> @@ -95,9 +95,3 @@
>     }
>     return res;
> }
> -
> -JNIEXPORT void JNICALL
> -Java_sun_nio_ch_EPoll_close0(JNIEnv *env, jclass c, jint epfd) {
> -    int res;
> -    RESTARTABLE(close(epfd), res);
> -}


From brian.burkhalter at oracle.com  Fri Apr 14 21:04:06 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Fri, 14 Apr 2017 14:04:06 -0700
Subject: JDK 10 RFR of 8178783: Java_sun_nio_ch_EPoll_close0 definition,
 but no sun.nio.ch.EPoll.close0 declaration.
In-Reply-To: <03FD0FB2-59FA-4017-9242-326C2B5C0842@oracle.com>
References: <B409B8DD-6726-4749-9271-EFD0CAE17289@oracle.com>
 <03FD0FB2-59FA-4017-9242-326C2B5C0842@oracle.com>
Message-ID: <ADD997D8-1EAF-45B8-9A8C-0FFE8AAC2AEA@oracle.com>

Damn I pushed it to JDK 9 ?

What to do?

On Apr 14, 2017, at 1:58 PM, Chris Hegarty <chris.hegarty at oracle.com> wrote:

> Looks good Brian.
> 
> -Chris
> 
>> On 14 Apr 2017, at 21:19, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>> 
>> This eliminates an unused method only.
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8178783
>> 
>> Thanks,
>> 
>> Brian
>> 
>> [1] diff
>> 
>> --- a/src/java.base/linux/native/libnio/ch/EPoll.c
>> +++ b/src/java.base/linux/native/libnio/ch/EPoll.c
>> @@ -95,9 +95,3 @@
>>    }
>>    return res;
>> }
>> -
>> -JNIEXPORT void JNICALL
>> -Java_sun_nio_ch_EPoll_close0(JNIEnv *env, jclass c, jint epfd) {
>> -    int res;
>> -    RESTARTABLE(close(epfd), res);
>> -}
> 


From brian.burkhalter at oracle.com  Wed Apr 19 14:37:47 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Wed, 19 Apr 2017 07:37:47 -0700
Subject: "unsafe" instances in sun.nio.fs.WindowsFileSystem
In-Reply-To: <00694934-e867-30a6-efde-714979d336c7@oracle.com>
References: <7540281ca3c7401c8de96b2cf7b11faa@gsdghkp03etn1.firmwide.corp.gs.com>
 <00694934-e867-30a6-efde-714979d336c7@oracle.com>
Message-ID: <ADD3A97D-423F-4EE0-920A-732E389BB0FC@oracle.com>

[Looping in nio-dev]

I can file an issue and look into it.

Brian

On Apr 18, 2017, at 11:44 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 19/04/2017 05:44, Chan, Sunny wrote:
> 
>> While reading the code for sun.nio.fs.WindowsFileSystemProvider and sun.nio.fs.WindowsUserDefinedFileAttributeView, I noticed that there is a private static variable to the Unsafe instance but it doesn't seems to be used anywhere in the code - am I missing something here or should I propose a patch to remove them?
>> 
> I suspect these are left over from past refactoring and shouldn't be an issue removing them.
> 
> -Alan


From chris.hegarty at oracle.com  Thu Apr 20 14:05:27 2017
From: chris.hegarty at oracle.com (Chris Hegarty)
Date: Thu, 20 Apr 2017 15:05:27 +0100
Subject: RFR [9] 8158270: MulticastSendReceiveTests.java failed with "Expected
 message not received"
Message-ID: <86B3A695-7A48-4AE6-80FD-BD66D158C929@oracle.com>

Following on from the work done in 8177536 [1] to avoid the Apple
Peer-to-Peer interface during multicast testing, the NIO test helper
class should be updated to do the same.

Note: the recently added test/lib/testlibrary/jdk/testlibrary/NetworkConfiguration.java
has such functionality, and the NIO tests could be updated to use
it a some future point, but for now I just want to do a minimal 
change in 9 to get the test reliably passing again.

diff --git a/test/java/nio/channels/DatagramChannel/NetworkConfiguration.java b/test/java/nio/channels/DatagramChannel/NetworkConfiguration.java
--- a/test/java/nio/channels/DatagramChannel/NetworkConfiguration.java
+++ b/test/java/nio/channels/DatagramChannel/NetworkConfiguration.java
@@ -57,6 +57,9 @@
         return ip6Interfaces.get(nif);
     }
 
+    private static final boolean isMacOS =
+            System.getProperty("os.name").contains("OS X");
+
     static NetworkConfiguration probe() throws IOException {
         Map<NetworkInterface,List<InetAddress>> ip4Interfaces =
             new HashMap<NetworkInterface,List<InetAddress>>();
@@ -67,8 +70,9 @@
         List<NetworkInterface> nifs = Collections
             .list(NetworkInterface.getNetworkInterfaces());
         for (NetworkInterface nif: nifs) {
-            // ignore intertaces that are down or don't support multicast
-            if (!nif.isUp() || !nif.supportsMulticast() || nif.isLoopback())
+            // ignore interfaces that are down or don't support multicast
+            if (!nif.isUp() || !nif.supportsMulticast() || nif.isLoopback()
+                || (isMacOS && nif.getName().contains("awdl")))
                 continue;
 
             List<InetAddress> addrs = Collections.list(nif.getInetAddresses());

-Chris.

[1] https://bugs.openjdk.java.net/browse/JDK-8177536

From Alan.Bateman at oracle.com  Fri Apr 21 08:42:55 2017
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Fri, 21 Apr 2017 09:42:55 +0100
Subject: RFR [9] 8158270: MulticastSendReceiveTests.java failed with
 "Expected message not received"
In-Reply-To: <86B3A695-7A48-4AE6-80FD-BD66D158C929@oracle.com>
References: <86B3A695-7A48-4AE6-80FD-BD66D158C929@oracle.com>
Message-ID: <92a1992a-0ef4-e9ef-e1c0-ba6d559458d7@oracle.com>

On 20/04/2017 15:05, Chris Hegarty wrote:

> Following on from the work done in 8177536 [1] to avoid the Apple
> Peer-to-Peer interface during multicast testing, the NIO test helper
> class should be updated to do the same.
The os.name is fixed as "Mac OS X" for several releases now so I think 
you can use that rather than contains. Others looks good.

-Alan

From chris.hegarty at oracle.com  Mon Apr 24 10:41:57 2017
From: chris.hegarty at oracle.com (Chris Hegarty)
Date: Mon, 24 Apr 2017 11:41:57 +0100
Subject: RFR [9] 8158270: MulticastSendReceiveTests.java failed with
 "Expected message not received"
In-Reply-To: <92a1992a-0ef4-e9ef-e1c0-ba6d559458d7@oracle.com>
References: <86B3A695-7A48-4AE6-80FD-BD66D158C929@oracle.com>
 <92a1992a-0ef4-e9ef-e1c0-ba6d559458d7@oracle.com>
Message-ID: <d2d50a24-7b5e-6978-66c0-f8bcc31356d4@oracle.com>

On 21/04/17 09:42, Alan Bateman wrote:
> On 20/04/2017 15:05, Chris Hegarty wrote:
>
>> Following on from the work done in 8177536 [1] to avoid the Apple
>> Peer-to-Peer interface during multicast testing, the NIO test helper
>> class should be updated to do the same.
> The os.name is fixed as "Mac OS X" for several releases now so I think
> you can use that rather than contains. Others looks good.

Thanks for the review. I'll make the change before pushing.

-Chris.

From brian.burkhalter at oracle.com  Wed Apr 26 21:49:46 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Wed, 26 Apr 2017 14:49:46 -0700
Subject: JDK 9 RFC on resolving some issues corresponding to apparently no
 longer failing tests
Message-ID: <2C236FE9-07C6-4651-94BD-C5A284D7D54A@oracle.com>

The issues [1, 2, 3] correspond to tests which were failing frequently until several changes were made to address some slow disks on certain testing infrastructure machines, increasing the timeout values of the tests, and splitting one of the tests into several smaller tests. Since these changes were made I have been routinely monitoring the list of test failures and none of these is among them. While this is not statistically significant in a pure sense, it seems as if the problems have likely been addressed, at least for these tests. I would therefore suggest using the issue IDs below to cover removing the ?intermittent? key from the corresponding tests.

There will be some other tests for which I will eventually propose the same tack.

Comments?

Thanks,

[1] https://bugs.openjdk.java.net/browse/JDK-8140263
[2] https://bugs.openjdk.java.net/browse/JDK-8174810
[3] https://bugs.openjdk.java.net/browse/JDK-8173386

From brian.burkhalter at oracle.com  Wed Apr 26 22:28:58 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Wed, 26 Apr 2017 15:28:58 -0700
Subject: JDK 9 RFC on 8077671: (fs) java/nio/file/FileSystem/Basic.java hangs
 accessing NFS mount
Message-ID: <51F522F3-D8D8-4FBE-B32E-092F13C86989@oracle.com>

With respect to [1], subsequent to the changes made to resolve [2] and [3], I have not observed an occurrence of [1]. Again while not being statistically significant to some confidence level or interval, it seems to me that the issue [1] could now be closed as ?Cannot Reproduce.?

Comment?

Thanks,

Brian

[1] https://bugs.openjdk.java.net/browse/JDK-8077671
[2] https://bugs.openjdk.java.net/browse/JDK-8173910
[3] https://bugs.openjdk.java.net/browse/JDK-8176237

From Alan.Bateman at oracle.com  Thu Apr 27 08:43:25 2017
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Thu, 27 Apr 2017 09:43:25 +0100
Subject: JDK 9 RFC on resolving some issues corresponding to apparently no
 longer failing tests
In-Reply-To: <2C236FE9-07C6-4651-94BD-C5A284D7D54A@oracle.com>
References: <2C236FE9-07C6-4651-94BD-C5A284D7D54A@oracle.com>
Message-ID: <bb522f70-a4db-61e9-7b8a-72234cf3a664@oracle.com>

On 26/04/2017 22:49, Brian Burkhalter wrote:

> The issues [1, 2, 3] correspond to tests which were failing frequently until several changes were made to address some slow disks on certain testing infrastructure machines, increasing the timeout values of the tests, and splitting one of the tests into several smaller tests. Since these changes were made I have been routinely monitoring the list of test failures and none of these is among them. While this is not statistically significant in a pure sense, it seems as if the problems have likely been addressed, at least for these tests. I would therefore suggest using the issue IDs below to cover removing the ?intermittent? key from the corresponding tests.
>
> There will be some other tests for which I will eventually propose the same tack.
>
Make sense and also close any remaining issues that complain about the 
tests timing out on this infrastructure. If there are new sightings then 
new bugs can be created.

-Alan

From Alan.Bateman at oracle.com  Thu Apr 27 08:46:35 2017
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Thu, 27 Apr 2017 09:46:35 +0100
Subject: JDK 9 RFC on 8077671: (fs) java/nio/file/FileSystem/Basic.java
 hangs accessing NFS mount
In-Reply-To: <51F522F3-D8D8-4FBE-B32E-092F13C86989@oracle.com>
References: <51F522F3-D8D8-4FBE-B32E-092F13C86989@oracle.com>
Message-ID: <a0beec95-714d-67c6-a65f-75a619104483@oracle.com>

On 26/04/2017 23:28, Brian Burkhalter wrote:

> With respect to [1], subsequent to the changes made to resolve [2] and [3], I have not observed an occurrence of [1]. Again while not being statistically significant to some confidence level or interval, it seems to me that the issue [1] could now be closed as ?Cannot Reproduce.?
>
> Comment?
>
I don't see any issues closing the bugs against this test.

-Alan

From brian.burkhalter at oracle.com  Fri Apr 28 19:43:06 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Fri, 28 Apr 2017 12:43:06 -0700
Subject: JDK test-only RFR of 8179452: Remove "intermittent" key from some
 tests which appear no longer to fail
Message-ID: <5DE21B40-6F5F-4739-A93C-D4295C5F56F5@oracle.com>

Please review at your convenience.

Issue:	https://bugs.openjdk.java.net/browse/JDK-8179452
Patch:	[1]

Thanks,

Brian

[1] diff

--- a/test/java/io/FileInputStream/LargeFileAvailable.java
+++ b/test/java/io/FileInputStream/LargeFileAvailable.java
@@ -24,7 +24,6 @@
 /*
  * @test
  * @bug 6402006 7030573 8011136
- * @key intermittent
  * @summary Test if available returns correct value when reading
  *          a large file.
  * @run main/timeout=300 LargeFileAvailable

--- a/test/java/nio/channels/FileChannel/LoopingTruncate.java
+++ b/test/java/nio/channels/FileChannel/LoopingTruncate.java
@@ -24,7 +24,6 @@
 /**
  * @test
  * @bug 8137121 8137230
- * @key intermittent
  * @summary (fc) Infinite loop FileChannel.truncate
  * @library /lib/testlibrary
  * @build jdk.testlibrary.Utils

--- a/test/java/nio/channels/FileChannel/Transfer.java
+++ b/test/java/nio/channels/FileChannel/Transfer.java
@@ -23,7 +23,6 @@
 
 /* @test
  * @bug 4434723 4482726 4559072 4795550 5081340 5103988 6984545
- * @key intermittent
  * @summary Test FileChannel.transferFrom and transferTo (use -Dseed=X to set PRNG seed)
  * @library ..
  * @library /lib/testlibrary/

--- a/test/java/nio/channels/FileChannel/Transfers.java
+++ b/test/java/nio/channels/FileChannel/Transfers.java
@@ -22,7 +22,6 @@
  */
 
 /* @test
- * @key intermittent
  * @summary Comprehensive test for FileChannel.transfer{From,To}
  * @bug 4708120
  * @author Mark Reinhold

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170428/aceff8af/attachment.html>

From lance.andersen at oracle.com  Fri Apr 28 19:52:11 2017
From: lance.andersen at oracle.com (Lance Andersen)
Date: Fri, 28 Apr 2017 15:52:11 -0400
Subject: JDK test-only RFR of 8179452: Remove "intermittent" key from some
 tests which appear no longer to fail
In-Reply-To: <5DE21B40-6F5F-4739-A93C-D4295C5F56F5@oracle.com>
References: <5DE21B40-6F5F-4739-A93C-D4295C5F56F5@oracle.com>
Message-ID: <53A42B88-7C01-4F24-BE2D-1DE09E5B9362@oracle.com>

+1
> On Apr 28, 2017, at 3:43 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> Please review at your convenience.
> 
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8179452
> Patch:	[1]
> 
> Thanks,
> 
> Brian
> 
> [1] diff
> 
> --- a/test/java/io/FileInputStream/LargeFileAvailable.java
> +++ b/test/java/io/FileInputStream/LargeFileAvailable.java
> @@ -24,7 +24,6 @@
> /*
>  * @test
>  * @bug 6402006 7030573 8011136
> - * @key intermittent
>  * @summary Test if available returns correct value when reading
>  *          a large file.
>  * @run main/timeout=300 LargeFileAvailable
> 
> --- a/test/java/nio/channels/FileChannel/LoopingTruncate.java
> +++ b/test/java/nio/channels/FileChannel/LoopingTruncate.java
> @@ -24,7 +24,6 @@
> /**
>  * @test
>  * @bug 8137121 8137230
> - * @key intermittent
>  * @summary (fc) Infinite loop FileChannel.truncate
>  * @library /lib/testlibrary
>  * @build jdk.testlibrary.Utils
> 
> --- a/test/java/nio/channels/FileChannel/Transfer.java
> +++ b/test/java/nio/channels/FileChannel/Transfer.java
> @@ -23,7 +23,6 @@
> 
> /* @test
>  * @bug 4434723 4482726 4559072 4795550 5081340 5103988 6984545
> - * @key intermittent
>  * @summary Test FileChannel.transferFrom and transferTo (use -Dseed=X to set PRNG seed)
>  * @library ..
>  * @library /lib/testlibrary/
> 
> --- a/test/java/nio/channels/FileChannel/Transfers.java
> +++ b/test/java/nio/channels/FileChannel/Transfers.java
> @@ -22,7 +22,6 @@
>  */
> 
> /* @test
> - * @key intermittent
>  * @summary Comprehensive test for FileChannel.transfer{From,To}
>  * @bug 4708120
>  * @author Mark Reinhold
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170428/1814169f/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170428/1814169f/oracle_sig_logo-0001.gif>

From joe.darcy at oracle.com  Fri Apr 28 19:55:23 2017
From: joe.darcy at oracle.com (joe darcy)
Date: Fri, 28 Apr 2017 12:55:23 -0700
Subject: JDK test-only RFR of 8179452: Remove "intermittent" key from some
 tests which appear no longer to fail
In-Reply-To: <53A42B88-7C01-4F24-BE2D-1DE09E5B9362@oracle.com>
References: <5DE21B40-6F5F-4739-A93C-D4295C5F56F5@oracle.com>
 <53A42B88-7C01-4F24-BE2D-1DE09E5B9362@oracle.com>
Message-ID: <911cca34-4ba5-7d6a-710f-b45a91aeeeb4@oracle.com>

Looks fine to me too.

-Joe

On 4/28/2017 12:52 PM, Lance Andersen wrote:
> +1
>> On Apr 28, 2017, at 3:43 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>>
>> Please review at your convenience.
>>
>> Issue:	https://bugs.openjdk.java.net/browse/JDK-8179452
>> Patch:	[1]
>>
>> Thanks,
>>
>> Brian
>>
>> [1] diff
>>
>> --- a/test/java/io/FileInputStream/LargeFileAvailable.java
>> +++ b/test/java/io/FileInputStream/LargeFileAvailable.java
>> @@ -24,7 +24,6 @@
>> /*
>>   * @test
>>   * @bug 6402006 7030573 8011136
>> - * @key intermittent
>>   * @summary Test if available returns correct value when reading
>>   *          a large file.
>>   * @run main/timeout=300 LargeFileAvailable
>>
>> --- a/test/java/nio/channels/FileChannel/LoopingTruncate.java
>> +++ b/test/java/nio/channels/FileChannel/LoopingTruncate.java
>> @@ -24,7 +24,6 @@
>> /**
>>   * @test
>>   * @bug 8137121 8137230
>> - * @key intermittent
>>   * @summary (fc) Infinite loop FileChannel.truncate
>>   * @library /lib/testlibrary
>>   * @build jdk.testlibrary.Utils
>>
>> --- a/test/java/nio/channels/FileChannel/Transfer.java
>> +++ b/test/java/nio/channels/FileChannel/Transfer.java
>> @@ -23,7 +23,6 @@
>>
>> /* @test
>>   * @bug 4434723 4482726 4559072 4795550 5081340 5103988 6984545
>> - * @key intermittent
>>   * @summary Test FileChannel.transferFrom and transferTo (use -Dseed=X to set PRNG seed)
>>   * @library ..
>>   * @library /lib/testlibrary/
>>
>> --- a/test/java/nio/channels/FileChannel/Transfers.java
>> +++ b/test/java/nio/channels/FileChannel/Transfers.java
>> @@ -22,7 +22,6 @@
>>   */
>>
>> /* @test
>> - * @key intermittent
>>   * @summary Comprehensive test for FileChannel.transfer{From,To}
>>   * @bug 4708120
>>   * @author Mark Reinhold
>>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>


From yangang at ec.com.cn  Sat Apr 29 13:58:59 2017
From: yangang at ec.com.cn (=?gbk?B?48a41Q==?=)
Date: Sat, 29 Apr 2017 13:58:59 +0800(CST)
Subject: =?gbk?B?Z2xhc3NmaXNoIHNlcnZlciBCdWZmZXIgb3ZlcmZsb3cu?=
Message-ID: <20170429055900.845051C0E76@mx3.ec.com.cn>

An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170429/05fbc925/attachment-0001.html>