Proposal for adding O_DIRECT support into JDK 9

[Lu, Yingqi]

Hi Brain/Alan,

Regarding to the native test, the easiest way I can think of is to call the "make" command from the Java test file (DirectIOTest.java). Please let me know if this is good enough or you have a better suggestion.

We already made all other changes.

Thanks,
Lucy

From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Monday, August 28, 2017 12:17 PM
To: Lu, Yingqi <yingqi.lu at intel.com>
Cc: Alan Bateman <Alan.Bateman at oracle.com>; Markle, Seth <smarkle at amazon.com>; nio-dev at openjdk.java.net
Subject: Re: Proposal for adding O_DIRECT support into JDK 9

Hi Lucy,

On Aug 28, 2017, at 10:32 AM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:


Thank you very much for your feedback! I will modify accordingly and send the webrev.06 here for review shortly.

Couple questions I want to make sure:

1.     Regarding to DirectIO test, do you mean uploading the native library into the build? If yes, we can do that for Linux 64bit and MacOS 64bit (from a virtual machine). I will need help from the community to add libraries that support other OSes.

I think Alan means *not* uploading a native library but instead having it built during the build of the test, i.e., dynamically.


2.     Could you please provide the line number for the comment below?
-        FileChannel.read(ByteByffer[])/write(ByteBuffer[]) loop over buffers but they should only do this when direct is true.

FileChannelImpl.java 220-226 and 299-305. I think that lines 216-226 and 295-305 could sit inside if (direct) {...} blocks.

From: Alan Bateman [mailto:Alan.Bateman at oracle.com]

I think Brian is looking through the tests but one question on DirectIO is whether you place to convert that into a native test that is compiled in the build. It may otherwise get forgotten.

I've looked over the tests before but will given them another pass.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170828/2424c05b/attachment.html>