[TEST-BUG] JDK 9 RFR of 8173910: (fs) java/nio/file/FileSystem/Basic.java should conditionally check FileStores

[Brian Burkhalter]

On Feb 6, 2017, at 2:30 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> Are there any other tests that run into this? I'm just wondering if this might be needed in the test infrastructure libraries.

I looked through the issues involving timeouts which are assigned to me and did not see at a glance any other tests which might be facing this problem.

> In any case, the approach seems okay although I think it would be better to move it into its own method to avoid cluttering main.

Agreed; separated out in updated version.

> I also have a small concern that it doesn't read the output/error streams from the `df` command and so could hang if there is a lot of output.

Calling inheritIO() on the ProcessBuilder before starting the Process should take care of this (new version, line 63).

> ProcessUtils is probably useful for this.

An updated patch is here: http://cr.openjdk.java.net/~bpb/8173910/webrev.01/

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170206/f576ce52/attachment-0001.html>