JDK 9 RFR of 8172547: (se) Selector.select(Long.MAX_VALUE) fires repeatedly

Roger Riggs Roger.Riggs at Oracle.com
Tue Jan 17 20:16:48 UTC 2017


Looks good Brian.

+1

Roger

On 1/17/2017 3:11 PM, Brian Burkhalter wrote:
>
> On Jan 16, 2017, at 12:12 PM, Alan Bateman <Alan.Bateman at oracle.com 
> <mailto:Alan.Bateman at oracle.com>> wrote:
>
>> On 13/01/2017 22:57, Brian Burkhalter wrote:
>>> Hi Roger,
>>>
>>> Thanks for the comments. Here is an update which takes them into 
>>> account:
>>>
>>> http://cr.openjdk.java.net/~bpb/8172547/webrev.01/ 
>>> <http://cr.openjdk.java.net/%7Ebpb/8172547/webrev.01/>
>>>
>>>
>> Aside from the typo in the comment that Christophpointed then then 
>> this looks good to me.
>
> Here is an updated patch with the typo in the implementation fixed and 
> line 77 of the test changed to t.join(SLEEP_MILLIS).
>
> http://cr.openjdk.java.net/~bpb/8172547/webrev.02/ 
> <http://cr.openjdk.java.net/%7Ebpb/8172547/webrev.02/>
>
> Thanks,
>
> Brian



More information about the nio-dev mailing list