JDK 10 RFR of 8184807: (ch) Clean up handling of some Windows function return values in libnio

Brian Burkhalter brian.burkhalter at oracle.com
Wed Jul 19 18:43:49 UTC 2017


Hi Vyom,

It’s too late for this patch, which had already been pushed before your message was sent, so perhaps in the future. However I am probably missing something, but I do not see any such unused variables in [1] or [2]. Would you please provide the specific line numbers in question?

Thanks,

Brian

[1] http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/4fb5f3049c2c/src/java.base/windows/native/libnio/ch/FileChannelImpl.c
[2] http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/4fb5f3049c2c/src/java.base/windows/native/libnio/ch/WindowsAsynchronousFileChannelImpl.c

On Jul 18, 2017, at 9:05 PM, vyom tewari <vyom.tewari at oracle.com> wrote:

> You can remove the unnecessary local variable "BOOL result" from WindowsAsynchronousFileChannelImpl.c & FileChannelImpl.c.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170719/0af6a243/attachment.html>


More information about the nio-dev mailing list