JDK 10 RFR of 8185092: Data race in FilterOutputStream.close
Claes Redestad
claes.redestad at oracle.com
Thu Jul 27 15:29:24 UTC 2017
On 07/27/2017 05:28 PM, Brian Burkhalter wrote:
> On Jul 27, 2017, at 6:50 AM, Claes Redestad <claes.redestad at oracle.com
> <mailto:claes.redestad at oracle.com>> wrote:
>
>> I suggest we instead apply the trick recently applied to FileInputStream
>> to avoid a similar startup regression and use a volatile boolean:
>
> Yes, that is what I suggested as an alternative in the initial review
> request:
Oops, missed that.
>
> On Jul 26, 2017, at 10:52 AM, Brian Burkhalter
> <brian.burkhalter at oracle.com <mailto:brian.burkhalter at oracle.com>> wrote:
>
>> An alternative would be a volatile boolean and a synchronization
>> block [3].
>> […]
>>
>> [3]http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/d93f2fd542b7/src/java.base/share/classes/java/io/FileOutputStream.java#l348
>
> I’ll change the patch accordingly.
Thanks!
/Claes
More information about the nio-dev
mailing list