JDK 10 RFR of JDK-8181394: Refactor shell test java/nio/file/Files/walkFileTree/find.sh to java

Alan Bateman Alan.Bateman at oracle.com
Thu Jun 1 10:51:36 UTC 2017


On 01/06/2017 11:22, Amy Lu wrote:
> java/nio/file/Files/walkFileTree/find.sh
>
> Please review this patch to refactor the shell test to java.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8181394
> webrev: http://cr.openjdk.java.net/~amlu/8181394/webrev.00/
>
> (I'll add @build jdk.test.lib.process.* if this is the "best" 
> workaround of CODETOOLS-7901986)
I think it would be cleaner if you merged FindTest, CreateFileTree and 
PrintFileTree. That should eliminate the need to launch PrintFileTree in 
its own VM, it would make the test setup simpler too. Also it would be 
nice to avoid SerializationUtils too.

-Alan




More information about the nio-dev mailing list