JDK 10 RFR of JDK-8181393: Refactor shell test Selector/lots_of_updates.sh and SocketChannel/Open.sh to java

[Amy Lu]

On 6/3/17 4:21 AM, Paul Sandoz wrote:
>> webrev: http://cr.openjdk.java.net/~amlu/8181393/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Eamlu/8181393/webrev.00/>
>>
>
> +1
>
> Out of curiosity is jtreg compilation of a test smart enough to know 
> of at least some of its dependencies.
>
>    24 /*
>    25  * @test
>    26  * @bug 6824477
>    27  * @summary Selector.select can fail with IOException "Invalid argument" on
>    28  *     Solaris if maximum number of file descriptors is less than 10000
>    29  * @requires (os.family != "windows")
>    30  * @library /test/lib
>    31  * @build LotsOfUpdates
>    32  * @run main LotsOfUpdatesTest
>    33  */
>    34
>    35 import jdk.test.lib.process.ProcessTools;
>    36
>    37 public class LotsOfUpdatesTest {
> Do you require line 31 since LotsOfUpdatesTest refers directly to 
> LotsOfUpdates?

Actually test works fine without line 31 because it refers as 
LotsOfUpdates.class.getName() (instead of a String "LotsOfUpdates").
I still want the at build in this case just to indicate explicitly that the 
test has dependency other than @library

Thank you Paul for reviewing. Pushed.

Thanks,
Amy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170605/54746eb8/attachment-0001.html>