JDK 10 RFR of JDK-8181396: Refactor shell test java/nio/file/Files/delete_on_close.sh to java

Amy Lu amy.lu at oracle.com
Mon Jun 5 16:11:41 UTC 2017


Good point!

Please review the updated version:
http://cr.openjdk.java.net/~amlu/8181396/webrev.01

Thanks,
Amy

On 6/5/17 10:52 PM, Alan Bateman wrote:
> On 05/06/2017 07:54, Amy Lu wrote:
>> java/nio/file/Files/delete_on_close.sh
>>
>> Please review this patch to refactor the shell test to java.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8181396
>> webrev: http://cr.openjdk.java.net/~amlu/8181396/webrev.00/
> I think it's a bit confusing to have both DeleteOnClose and 
> DeleteOnTerminate, esp. when DeleteOnTerminate creates a file with 
> DELETE_ON_CLOSE. Instead couldn't DeleteOnClose just launch itself to 
> create the file?
>
> -Alan



More information about the nio-dev mailing list