JDK 10 RFR of JDK-8181394: Refactor shell test java/nio/file/Files/walkFileTree/find.sh to java

[Alan Bateman]

On 12/06/2017 09:35, Amy Lu wrote:
> On 6/7/17 11:04 AM, Amy Lu wrote:
>> On 6/6/17 9:49 PM, Alan Bateman wrote:
>>>> http://cr.openjdk.java.net/~amlu/8181394/webrev.01
>>>>
>>>> CreateFileTree is also used by other tests, no change.
>>>>
>>> This looks much better. At some point we might decide to remove the 
>>> cleanUp method as it can often be useful to leave the file tree 
>>> around, esp. if there is a test failure. 
>> Got your point, let me do this change in this patch.
>>
>> Please review: http://cr.openjdk.java.net/~amlu/8181394/webrev.02/
>> ( For your reference: 
>> http://cr.openjdk.java.net/~amlu/8181394/FindTest.webrev.01_webrev.02.diff 
>> )
>
> Hi, Alan
>
> Is this fine to go?
>
Yes, I think the update version is good.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170612/4b7a5b72/attachment.html>