JDK 9 RFR of 8175209: Account for race condition in java/nio/channels/AsynchronousSocketChannel/Basic.java

Hamlin Li huaming.li at oracle.com
Mon Mar 6 03:39:48 UTC 2017


Hi Brian,

It looks better to me, and it will be even better if you could scale the 
1000 times loop with a timeout factor, that means loop more times when 
timeout factor is greater.

BTW, I'm not a official reviewer.

Thank you

-Hamlin


On 2017/3/4 5:57, Brian Burkhalter wrote:
> Here is a patch changed per my interpretation of Hamlin’s suggestion:
>
> http://cr.openjdk.java.net/~bpb/8175209/webrev.02/ 
> <http://cr.openjdk.java.net/%7Ebpb/8175209/webrev.02/>
>
> Also “new Random()" was replaced with RandomFactory.getRandom().
>
> Thanks,
>
> Brian
>
> On Mar 3, 2017, at 11:25 AM, Brian Burkhalter 
> <brian.burkhalter at oracle.com> wrote:
>
>> Your suggestion however might make it even more likely that the 
>> expected exception will be seen so I will investigate changing my patch.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170306/7807ab2d/attachment-0001.html>


More information about the nio-dev mailing list