JDK 9 RFR of 8175209: Account for race condition in java/nio/channels/AsynchronousSocketChannel/Basic.java

[Alan Bateman]

On 06/03/2017 16:20, Brian Burkhalter wrote:

> On Mar 6, 2017, at 8:11 AM, Alan Bateman <Alan.Bateman at oracle.com 
> <mailto:Alan.Bateman at oracle.com>> wrote:
>
>> The "give time for the socket buffer to fill up" changes look okay 
>> but the "// attempt concurrent writes"  from L357 looks a bit ugly 
>> and should not be necessary. Can we leave the latter out of the 
>> changes and only come back to it if there are further stability issues?
>
> I concur. So you’re OK with
>
> http://cr.openjdk.java.net/~bpb/8175209/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ebpb/8175209/webrev.01/>
>
> ?
>
Looks fine. The use of the random library in the previous version was 
okay too although I'm pretty sure the issue is the sleep and your 
changes should significantly reduce the possibility of this.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170306/638a8bb5/attachment.html>