JDK 9 RFR of 8176332: Increase sleep time in java/nio/channels/Selector/ChangingInterests.java write1()
Alan Bateman
Alan.Bateman at oracle.com
Thu Mar 9 11:43:58 UTC 2017
On 08/03/2017 20:46, Brian Burkhalter wrote:
> On Mar 8, 2017, at 8:10 AM, Alan Bateman <Alan.Bateman at oracle.com
> <mailto:Alan.Bateman at oracle.com>> wrote:
>
>>> To reduce the odds of this happening, this patch increases the pause
>>> time from 50 to 150 ms, an execution time increase for the test of
>>> 400 ms total as the method write1() is invoked four times.
>>>
>> This looks okay (longer is okay too) although it would be nice if
>> there were a way to avoid the sleep.
>
> I created an alternative version
> http://cr.openjdk.java.net/~bpb/8176332/webrev.01/
> <http://cr.openjdk.java.net/%7Ebpb/8176332/webrev.01/> which does not
> depend on the SocketChannel becoming readable after a fixed sleep.
> This passed regression tests on all the usual platforms.
>
This changes the test in a subtle way but I think it is okay. Can you
fix the formatting of L58-59 before you push this?
-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170309/c6b8fd24/attachment.html>
More information about the nio-dev
mailing list