JDK 9 RFR of 8176744: Improve internal timing of java/nio/channels/Selector/SelectAndClose.java

Brian Burkhalter brian.burkhalter at oracle.com
Tue Mar 14 20:39:35 UTC 2017


Hi Roger, Alan,

On Mar 14, 2017, at 1:31 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 14/03/2017 16:47, Brian Burkhalter wrote:
>> Please review this test-only fix at your convenience.
>> 
>> Issue:	https://bugs.openjdk.java.net/browse/JDK-8176744
>> Patch:	http://cr.openjdk.java.net/~bpb/8176744/webrev.00/
>> 
>> Deal with another flaky use of sleep().
>> 
> Mostly, it's still possible that 500ms isn't sufficient for select to block when the machine is overloaded with concurrent tests. So you could bump that up a bit. I agree with Roger on "awakened" and "closed", they should be volatile.

Here’s an updated version:

http://cr.openjdk.java.net/~bpb/8176744/webrev.01/

Thanks,

Brian


More information about the nio-dev mailing list