From dalibor.topic at oracle.com Thu May 4 11:50:50 2017 From: dalibor.topic at oracle.com (dalibor topic) Date: Thu, 4 May 2017 13:50:50 +0200 Subject: glassfish server Buffer overflow. In-Reply-To: <20170429055900.845051C0E76@mx3.ec.com.cn> References: <20170429055900.845051C0E76@mx3.ec.com.cn> Message-ID: Hi, GlassFish is not being developed in the OpenJDK Community. Please go to https://github.com/javaee/glassfish for information about GlassFish development. cheers, dalibor topic On 29.04.2017 07:58, ?? wrote: > I check glassfish server log (java EE application server) > > > > Get buffer overflow error: -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From mikael.vidstedt at oracle.com Tue May 9 21:29:13 2017 From: mikael.vidstedt at oracle.com (Mikael Vidstedt) Date: Tue, 9 May 2017 14:29:13 -0700 Subject: RFR(S): 8180003: Remove sys/ prefix from poll.h and signal.h includes Message-ID: Please review this small change which removes the sys/ prefix from a bunch of includes of poll.h and signal.h. hotspot: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/hotspot/webrev/ jdk: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/jdk/webrev/ Using the sys/ prefix works on many platforms, but the posix spec makes it clear that the poll.h and signal.h header files should be included without the prefix. I have verified that this change works on all the Oracle supported platforms, but I could use some help verifying it on AIX. Cheers, Mikael -------------- next part -------------- An HTML attachment was scrubbed... URL: From brian.burkhalter at oracle.com Tue May 9 21:45:04 2017 From: brian.burkhalter at oracle.com (Brian Burkhalter) Date: Tue, 9 May 2017 14:45:04 -0700 Subject: RFR(S): 8180003: Remove sys/ prefix from poll.h and signal.h includes In-Reply-To: References: Message-ID: <83DEDA3B-2BD5-4F99-A3BE-2F3AE8F2C39B@oracle.com> On May 9, 2017, at 2:29 PM, Mikael Vidstedt wrote: > Please review this small change which removes the sys/ prefix from a bunch of includes of poll.h and signal.h. > > hotspot: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/hotspot/webrev/ > jdk: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/jdk/webrev/ The JDK NIO changes look fine at least. > Using the sys/ prefix works on many platforms, but the posix spec makes it clear that the poll.h and signal.h header files should be included without the prefix. Just had to look ? [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/poll.h.html [2] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html > I have verified that this change works on all the Oracle supported platforms, but I could use some help verifying it on AIX. Good about the Oracle platforms. Brian -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.holmes at oracle.com Tue May 9 23:19:23 2017 From: david.holmes at oracle.com (David Holmes) Date: Wed, 10 May 2017 09:19:23 +1000 Subject: RFR(S): 8180003: Remove sys/ prefix from poll.h and signal.h includes In-Reply-To: References: Message-ID: <3e50ead4-6b81-c0f2-1654-847390981357@oracle.com> Hi Mikael, To repeat myself from: http://mail.openjdk.java.net/pipermail/portola-dev/2017-April/000025.html Changes look okay. I agree with the rationale. Looking at actual implementations, linux and mac OS are trivially fine (poll.h just includes sys/poll.h). Solaris is non-trivially fine - poll.h does more than what sys/poll.h does, but nothing that affects our sources. Thanks, David :) On 10/05/2017 7:29 AM, Mikael Vidstedt wrote: > > Please review this small change which removes the sys/ prefix from a bunch of includes of poll.h and signal.h. > > hotspot: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/hotspot/webrev/ > jdk: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/jdk/webrev/ > > Using the sys/ prefix works on many platforms, but the posix spec makes it clear that the poll.h and signal.h header files should be included without the prefix. > > I have verified that this change works on all the Oracle supported platforms, but I could use some help verifying it on AIX. > > Cheers, > Mikael > From brian.burkhalter at oracle.com Wed May 10 18:42:39 2017 From: brian.burkhalter at oracle.com (Brian Burkhalter) Date: Wed, 10 May 2017 11:42:39 -0700 Subject: JDK 9 RFR of test-only 8180085: (ch) java/nio/channels/SocketChannel/VectorIO.java: add debug instrumentation Message-ID: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8180085 Patch: http://cr.openjdk.java.net/~bpb/8180085/webrev.00/ Add some print statements potentially useful in solving https://bugs.openjdk.java.net/browse/JDK-8177801. Thanks, Brian From Alan.Bateman at oracle.com Thu May 11 06:52:21 2017 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 11 May 2017 07:52:21 +0100 Subject: JDK 9 RFR of test-only 8180085: (ch) java/nio/channels/SocketChannel/VectorIO.java: add debug instrumentation In-Reply-To: References: Message-ID: <7b9e949c-32c5-e127-0ed4-5678c888fdcd@oracle.com> On 10/05/2017 19:42, Brian Burkhalter wrote: > Please review at your convenience. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8180085 > Patch: http://cr.openjdk.java.net/~bpb/8180085/webrev.00/ > > Add some print statements potentially useful in solving https://bugs.openjdk.java.net/browse/JDK-8177801. > Looks okay. Style-wise then I guess I would be braces when added the then-else but that is a minor point in the bug for the intermittent test failures. -Alan From brian.burkhalter at oracle.com Thu May 11 14:23:50 2017 From: brian.burkhalter at oracle.com (Brian Burkhalter) Date: Thu, 11 May 2017 07:23:50 -0700 Subject: JDK 9 RFR of test-only 8180085: (ch) java/nio/channels/SocketChannel/VectorIO.java: add debug instrumentation In-Reply-To: <7b9e949c-32c5-e127-0ed4-5678c888fdcd@oracle.com> References: <7b9e949c-32c5-e127-0ed4-5678c888fdcd@oracle.com> Message-ID: <767132AD-0F00-461F-90F9-46DD9A965C38@oracle.com> On May 10, 2017, at 11:52 PM, Alan Bateman wrote: >> Please review at your convenience. >> >> Issue: https://bugs.openjdk.java.net/browse/JDK-8180085 >> Patch: http://cr.openjdk.java.net/~bpb/8180085/webrev.00/ >> >> Add some print statements potentially useful in solvinghttps://bugs.openjdk.java.net/browse/JDK-8177801. >> > Looks okay. Style-wise then I guess I would be braces when added the then-else but that is a minor point in the bug for the intermittent test failures. I prefer that style as well but was retaining the existing style in the test. Might change to that before pushing. Thanks, Brian -------------- next part -------------- An HTML attachment was scrubbed... URL: From brian.burkhalter at oracle.com Tue May 16 15:42:59 2017 From: brian.burkhalter at oracle.com (Brian Burkhalter) Date: Tue, 16 May 2017 08:42:59 -0700 Subject: JDK test-only RFR of 8180431: Remove "intermittent" keyword from some no longer failing NIO tests Message-ID: <3283C0D2-0563-4190-936E-F20DBC30289E@oracle.com> Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8180431 Patch: [1] The issues linked to the present issue are intended to be resolve as ?Cannot Reproduce? so it would be better to remove the ?intermittent? keyword first. The issue https://bugs.openjdk.java.net/browse/JDK-8078590 will also be resolved as CNR but the test it refers to has other intermittent failures, e.g., https://bugs.openjdk.java.net/browse/JDK-8161991, so the keyword will be left as-is in that test for now. Thanks, Brian [1] Hg mq diff --- a/test/java/nio/channels/Selector/SelectAndClose.java +++ b/test/java/nio/channels/Selector/SelectAndClose.java @@ -23,7 +23,6 @@ /* @test * @bug 5004077 - * @key intermittent * @summary Check blocking of select and close */ diff --git a/test/java/nio/channels/Selector/WakeupAfterClose.java b/test/java/nio/channels/Selector/WakeupAfterClose.java --- a/test/java/nio/channels/Selector/WakeupAfterClose.java +++ b/test/java/nio/channels/Selector/WakeupAfterClose.java @@ -24,7 +24,6 @@ /* @test * @bug 6524172 * @summary Invoking wakeup on closed Selector can throw NPE if close resets interrupt status - * @key intermittent */ -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alan.Bateman at oracle.com Tue May 16 15:44:10 2017 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 16 May 2017 16:44:10 +0100 Subject: JDK test-only RFR of 8180431: Remove "intermittent" keyword from some no longer failing NIO tests In-Reply-To: <3283C0D2-0563-4190-936E-F20DBC30289E@oracle.com> References: <3283C0D2-0563-4190-936E-F20DBC30289E@oracle.com> Message-ID: <0f5fba13-d244-8236-12b5-3377131f08d7@oracle.com> Looks fine. On 16/05/2017 16:42, Brian Burkhalter wrote: > Please review at your convenience. > > Issue:https://bugs.openjdk.java.net/browse/JDK-8180431 > Patch:[1] > > The issues linked to the present issue are intended to be resolve as > ?Cannot Reproduce? so it would be better to remove the ?intermittent? > keyword first. The issue > https://bugs.openjdk.java.net/browse/JDK-8078590 will also be resolved > as CNR but the test it refers to has other intermittent failures, > e.g., https://bugs.openjdk.java.net/browse/JDK-8161991, so the keyword > will be left as-is in that test for now. > > Thanks, > > Brian > > [1] Hg mq diff > > --- a/test/java/nio/channels/Selector/SelectAndClose.java > +++ b/test/java/nio/channels/Selector/SelectAndClose.java > @@ -23,7 +23,6 @@ > > > /* @test > * @bug 5004077 > - * @key intermittent > * @summary Check blocking of select and close > */ > > > diff --git a/test/java/nio/channels/Selector/WakeupAfterClose.java > b/test/java/nio/channels/Selector/WakeupAfterClose.java > --- a/test/java/nio/channels/Selector/WakeupAfterClose.java > +++ b/test/java/nio/channels/Selector/WakeupAfterClose.java > @@ -24,7 +24,6 @@ > /* @test > * @bug 6524172 > * @summary Invoking wakeup on closed Selector can throw NPE if close > resets interrupt status > - * @key intermittent > */ -------------- next part -------------- An HTML attachment was scrubbed... URL: From amy.lu at oracle.com Fri May 26 02:42:07 2017 From: amy.lu at oracle.com (Amy Lu) Date: Fri, 26 May 2017 10:42:07 +0800 Subject: JDK 10 RFR of JDK-8181126: Refactor shell test java/nio/Buffer/LimitDirectMemory.sh to java Message-ID: <2c1c726a-bbc4-21ae-82dc-13433eb351c9@oracle.com> java/nio/Buffer/LimitDirectMemory.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8181126 webrev: http://cr.openjdk.java.net/~amlu/8181126/webrev.00/ Thanks, Amy From paul.sandoz at oracle.com Tue May 30 19:54:19 2017 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Tue, 30 May 2017 12:54:19 -0700 Subject: JDK 10 RFR of JDK-8181126: Refactor shell test java/nio/Buffer/LimitDirectMemory.sh to java In-Reply-To: <2c1c726a-bbc4-21ae-82dc-13433eb351c9@oracle.com> References: <2c1c726a-bbc4-21ae-82dc-13433eb351c9@oracle.com> Message-ID: <71EA9FDB-E8FA-410A-A812-BCC17233ABD3@oracle.com> +1 Paul. > On 25 May 2017, at 19:42, Amy Lu wrote: > > java/nio/Buffer/LimitDirectMemory.sh > > Please review this patch to refactor the shell test to java. > > bug: https://bugs.openjdk.java.net/browse/JDK-8181126 > webrev: http://cr.openjdk.java.net/~amlu/8181126/webrev.00/ > > Thanks, > Amy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 841 bytes Desc: Message signed with OpenPGP using GPGMail URL: From amy.lu at oracle.com Wed May 31 03:57:27 2017 From: amy.lu at oracle.com (Amy Lu) Date: Wed, 31 May 2017 11:57:27 +0800 Subject: JDK 10 RFR of JDK-8181301: Refactor shell test AsynchronousChannelGroup/run_any_task.sh to java Message-ID: <1890eba3-8030-3ca6-ef5a-3e381c977eac@oracle.com> java/nio/channels/AsynchronousChannelGroup/run_any_task.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8181301 webrev: http://cr.openjdk.java.net/~amlu/8181301/webrev.00/ Thanks, Amy From Alan.Bateman at oracle.com Wed May 31 08:01:09 2017 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 31 May 2017 09:01:09 +0100 Subject: JDK 10 RFR of JDK-8181301: Refactor shell test AsynchronousChannelGroup/run_any_task.sh to java In-Reply-To: <1890eba3-8030-3ca6-ef5a-3e381c977eac@oracle.com> References: <1890eba3-8030-3ca6-ef5a-3e381c977eac@oracle.com> Message-ID: <99f549ea-c64c-6994-48e2-e17c078274a8@oracle.com> On 31/05/2017 04:57, Amy Lu wrote: > java/nio/channels/AsynchronousChannelGroup/run_any_task.sh > > Please review this patch to refactor the shell test to java. > > bug: https://bugs.openjdk.java.net/browse/JDK-8181301 > webrev: http://cr.openjdk.java.net/~amlu/8181301/webrev.00/ This looks okay to me although I think I would put the test description before the imports in AsExecutor so you don't have to skip over those to see how the test is run. A minor nit is that the JAR file can be "privileged.jar" rather than "Privileged.jar". -Alan From Alan.Bateman at oracle.com Wed May 31 08:07:30 2017 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 31 May 2017 09:07:30 +0100 Subject: JDK 10 RFR of JDK-8181126: Refactor shell test java/nio/Buffer/LimitDirectMemory.sh to java In-Reply-To: <2c1c726a-bbc4-21ae-82dc-13433eb351c9@oracle.com> References: <2c1c726a-bbc4-21ae-82dc-13433eb351c9@oracle.com> Message-ID: On 26/05/2017 03:42, Amy Lu wrote: > java/nio/Buffer/LimitDirectMemory.sh > > Please review this patch to refactor the shell test to java. > > bug: https://bugs.openjdk.java.net/browse/JDK-8181126 > webrev: http://cr.openjdk.java.net/~amlu/8181126/webrev.00/ This looks okay to me. -Alan From amy.lu at oracle.com Wed May 31 08:10:45 2017 From: amy.lu at oracle.com (Amy Lu) Date: Wed, 31 May 2017 16:10:45 +0800 Subject: JDK 10 RFR of JDK-8181301: Refactor shell test AsynchronousChannelGroup/run_any_task.sh to java In-Reply-To: <99f549ea-c64c-6994-48e2-e17c078274a8@oracle.com> References: <1890eba3-8030-3ca6-ef5a-3e381c977eac@oracle.com> <99f549ea-c64c-6994-48e2-e17c078274a8@oracle.com> Message-ID: On 5/31/17 4:01 PM, Alan Bateman wrote: > On 31/05/2017 04:57, Amy Lu wrote: > >> java/nio/channels/AsynchronousChannelGroup/run_any_task.sh >> >> Please review this patch to refactor the shell test to java. >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8181301 >> webrev: http://cr.openjdk.java.net/~amlu/8181301/webrev.00/ > This looks okay to me although I think I would put the test > description before the imports in AsExecutor so you don't have to skip > over those to see how the test is run. A minor nit is that the JAR > file can be "privileged.jar" rather than "Privileged.jar". > > -Alan Thank you Alan! Webrev updated according to the suggestions: http://cr.openjdk.java.net/~amlu/8181301/webrev.01 Thanks, Amy From Alan.Bateman at oracle.com Wed May 31 08:39:17 2017 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 31 May 2017 09:39:17 +0100 Subject: JDK 10 RFR of JDK-8181301: Refactor shell test AsynchronousChannelGroup/run_any_task.sh to java In-Reply-To: References: <1890eba3-8030-3ca6-ef5a-3e381c977eac@oracle.com> <99f549ea-c64c-6994-48e2-e17c078274a8@oracle.com> Message-ID: On 31/05/2017 09:10, Amy Lu wrote: > Thank you Alan! > > Webrev updated according to the suggestions: > http://cr.openjdk.java.net/~amlu/8181301/webrev.01 > Looks good.