RFR(S): 8180003: Remove sys/ prefix from poll.h and signal.h includes

Brian Burkhalter brian.burkhalter at oracle.com
Tue May 9 21:45:04 UTC 2017


On May 9, 2017, at 2:29 PM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:

> Please review this small change which removes the sys/ prefix from a bunch of includes of poll.h and signal.h.
> 
> hotspot: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/hotspot/webrev/
> jdk: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/jdk/webrev/

The JDK NIO changes look fine at least.

> Using the sys/ prefix works on many platforms, but the posix spec makes it clear that the poll.h and signal.h header files should be included without the prefix.

Just had to look …

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/poll.h.html
[2] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html

> I have verified that this change works on all the Oracle supported platforms, but I could use some help verifying it on AIX.

Good about the Oracle platforms.

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170509/08268754/attachment.html>


More information about the nio-dev mailing list