JDK 10 RFR of 8147615: (fc) FileChannelImpl has no finalizer

Roger Riggs Roger.Riggs at Oracle.com
Fri Oct 6 13:34:55 UTC 2017


Hi Brian,

Sorry for the delay.

FileChannelImpl:

- line 117:  A lambda could be used instead of the explicit Closer class.

    () -> fdAccess.close(fd)
    // Note: fd is the argument (not the field) to prevent the lambda
    from capturing this.


In the test:
  - Perhaps a bit more descriptive name than just "Cleaner" perhaps 
CleanerTest or...

  - Add @modules java.management - so the test will not be run unless 
the runtime includes management

   Thanks, Roger

On 10/3/2017 10:10 AM, Brian Burkhalter wrote:
> This message reprises the thread [1]. A new revision of the patch for [2] which accounts for the recent
> refactoring of FileDescriptor closing [3] is here:
>
> http://cr.openjdk.java.net/~bpb/8147615/webrev.02/
>
> Thanks,
>
> Brian
>
> [1] http://mail.openjdk.java.net/pipermail/nio-dev/2017-September/004463.html
> [2] https://bugs.openjdk.java.net/browse/JDK-8147615
> [3] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-September/049231.html



More information about the nio-dev mailing list