Proposal for adding O_DIRECT support into JDK 9

[Lu, Yingqi]

Hi Alan,

Here is the version 18 of the patch. Following your suggestion, I changed statvfs to statvfs64 in FileDispatcherImpl.c.

http://cr.openjdk.java.net/~kkharbas/8164900/webrev.18/

Thanks,
Lucy


From: nio-dev [mailto:nio-dev-bounces at openjdk.java.net] On Behalf Of Lu, Yingqi
Sent: Monday, October 09, 2017 7:48 AM
To: Alan Bateman <Alan.Bateman at oracle.com>
Cc: nio-dev at openjdk.java.net
Subject: Re: Proposal for adding O_DIRECT support into JDK 9

Hi Alan,

Thank you for reviewing it. I will submit version 18 today to address the issue.

Thanks,
Lucy

Sent from my iPhone

On Oct 9, 2017, at 12:38 AM, Alan Bateman <Alan.Bateman at oracle.com<mailto:Alan.Bateman at oracle.com>> wrote:
On 06/10/2017 18:39, Lu, Yingqi wrote:

Hi Brian,

Here is the version 17 of the patch http://cr.openjdk.java.net/~kkharbas/8164900/webrev.17/<http://cr.openjdk.java.net/%7Ekkharbas/8164900/webrev.17/>

It is generated against http://hg.openjdk.java.net/jdk10/master/

Please let me know if there is anything missing. Thank you very much for your help!

I went through webrev.17 and it looks good. One thing check is statvfs usage in FileDispatcherImpl.c, I assume this should statvfs64 to allow for 32-bit builds and >2GB files.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20171009/7f50b148/attachment.html>