Proposal for adding O_DIRECT support into JDK 9

[Lu, Yingqi]

Hi Brian,

I will add the Solaris check for all the tests now and wait for your feedback on the additional tests. All these changes will go into webrev.08.

Thanks,
Lucy


From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Friday, September 01, 2017 7:47 AM
To: Lu, Yingqi <yingqi.lu at intel.com>
Cc: Alan Bateman <Alan.Bateman at oracle.com>; nio-dev at openjdk.java.net
Subject: Re: Proposal for adding O_DIRECT support into JDK 9

Hi Lucy,

On Aug 31, 2017, at 3:49 PM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:


Here is the webrev.07 version of the patch:http://cr.openjdk.java.net/~kkharbas/8164900/webrev.07/

In this version, I have addressed the following issues:

2.      Added the filesystem type check on Solaris for DirectIOTest.
This check should be in all the tests as they all fail on Solaris. Perhaps the code could be put in a static method on DirectIOTest which could be called by all five tests?


3.      Checked if there is an equivalent system call like mincore in Windows to enable DirectIOTest for Windows. I could not find anything unfortunately.

OK I do not think that is a big deal as this is not the target area anyway.


Issues that are still open:

1.      How should we address the issue of AIX OS does not support setting O_DIRECT after the open()

It would be good to hear others comments as well on this.


Please take a look at this version and let us know your feedback. I would also like to learn what will be a proper approach to solve the AIX issue and what kind of details we need to provide for the exception messages. I will try to incorporate all of those changes into the next version.
I'll try to get back to you on these points today.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170901/7e944025/attachment-0001.html>