Proposal for adding O_DIRECT support into JDK 9

[Lu, Yingqi]

Hi Hamlin,

Thank you for the information. I will look into this issue.

Volker, please take a look as well and let us know if you know a solution to it.

Thanks,
Lucy

From: huaming.li at oracle.com [mailto:huaming.li at oracle.com]
Sent: Thursday, September 07, 2017 12:52 AM
To: Lu, Yingqi <yingqi.lu at intel.com>; Brian Burkhalter <brian.burkhalter at oracle.com>
Cc: nio-dev at openjdk.java.net
Subject: Re: Proposal for adding O_DIRECT support into JDK 9


Hi Lucy,

Just for your information.

I applied the patch, face following compilation error, I worked on Mac, Darwin Kernel Version 16.7.0.

/workspace/jdk/jdk10/jdk/src/java.base/unix/classes/sun/nio/fs/UnixChannelFactory.java:247: error: cannot find symbol
            oflags |= O_DIRECT;
                      ^
  symbol:   variable O_DIRECT
  location: class UnixChannelFactory

Thank you

-Hamlin

On 07/09/2017 2:38 AM, Lu, Yingqi wrote:
Hi Brian,

The webrev.08 is available at http://cr.openjdk.java.net/~kkharbas/8164900/webrev.08/<http://cr.openjdk.java.net/%7Ekkharbas/8164900/webrev.08/>

It supposes to address the following the issues. Please let me know if there is anything missing.

Thanks,
Lucy

From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Tuesday, September 05, 2017 3:35 PM
To: Lu, Yingqi <yingqi.lu at intel.com><mailto:yingqi.lu at intel.com>
Cc: huaming.li at oracle.com<mailto:huaming.li at oracle.com>; nio-dev at openjdk.java.net<mailto:nio-dev at openjdk.java.net>
Subject: Re: Proposal for adding O_DIRECT support into JDK 9

Hi Lucy,

Based on what I recall seeing in the e-mail thread since the previous version this sounds to be about right.

Thanks,

Brian

On Sep 5, 2017, at 3:27 PM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:



Based on the recent feedback I receive, I am going to make following changes into the next version of the patch. Please let me know if there is anything missing or not correctly understood.


1.     Apply Volker's updated patch for AIX DirectIO support.

2.     Add 2 static functions inside IOUtil.java for position check and remaining buffer size check. Change IOUtil.java and FileChannelImpl.java accordingly.

3.     Put Solaris Filesystem check into DirectIOTest.java and use it for all the existing tests.

4.     Add 1 additional test for both read and write to test buffer location alignment.

5.     Add 1 test case into ReadDirect test represent the case file size is smaller than block size.

6.     Remove 4096 from all the tests and replace it with a meaningful variable.

7.     Change the function name inside the tests to be more meaningful.
Please let me know if there is anything missing.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170907/ac216c5a/attachment.html>