Proposal for adding O_DIRECT support into JDK 9

Brian Burkhalter brian.burkhalter at oracle.com
Wed Sep 13 01:03:40 UTC 2017


Hi Lucy,

On Sep 12, 2017, at 3:58 PM, Lu, Yingqi <yingqi.lu at intel.com> wrote:

> http://cr.openjdk.java.net/~kkharbas/8164900/webrev.10/
>  
> In this version, two issues have been addressed:
>  
> 1.     Add description on the notion “block” in FileStore:getBlockSize

FileStore.java
116: “isthe smallest stoage” -> “is the smallest storage”
128: “if operation” -> “if the operation”

> 2.     Move alignment check from IOUtil to Util
>  
> There is one remaining issue: we check alignment on buffer size and channel position inside both FileChannelImpl and IOUtil. I looked at the code and think we might be able to remove the checks inside readFromNativeBuffer

readIntoNativeBuffer()

> and writeFromNativeBuffer.

It does look as if either the FileChannelImpl or the IOUtil checks could be removed.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170912/8296793b/attachment-0001.html>


More information about the nio-dev mailing list