Proposal for adding O_DIRECT support into JDK 9

[Alan Bateman]

On 14/09/2017 23:28, Lu, Yingqi wrote:
>
> Hi Brian and Alan,
>
> Please find the version 13 of the patch is available at 
> http://cr.openjdk.java.net/~kkharbas/8164900/webrev.13/ 
> <http://cr.openjdk.java.net/%7Ekkharbas/8164900/webrev.13/>
>
> In this version, I have addressed Alan’s most recent feedback.
>
>
I think we are close but I'm still concerned about the position check in 
FileChannel.read/write. This has to be done while holding positionLock, 
otherwise there is no guarantee that the position hasn't changed (I 
wasn't clear in my mail yesterday).

One other issue is in IOUtil.read where the alignment check is done on 
dst.remaining(), it should be "rem". The other checks look correct.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170915/cfb84463/attachment.html>