Proposal for adding O_DIRECT support into JDK 9

[Lu, Yingqi]

Hi Volker,

Thank you very much for testing the patch. Really appreciate your help :)

Thanks,
Lucy

>-----Original Message-----
>From: Volker Simonis [mailto:volker.simonis at gmail.com]
>Sent: Friday, September 15, 2017 5:29 AM
>To: Lu, Yingqi <yingqi.lu at intel.com>
>Cc: Brian Burkhalter <brian.burkhalter at oracle.com>; nio-dev at openjdk.java.net
>Subject: Re: Proposal for adding O_DIRECT support into JDK 9
>
>Hi Lucy,
>
>I just wanted to report that your last version (i.e. webrev.13) compiles fine on AIX
>and passes all the new directio tests.
>
>Thanks,
>Volker
>
>
>On Fri, Sep 15, 2017 at 12:28 AM, Lu, Yingqi <yingqi.lu at intel.com> wrote:
>> Hi Brian and Alan,
>>
>>
>>
>> Please find the version 13 of the patch is available at
>> http://cr.openjdk.java.net/~kkharbas/8164900/webrev.13/
>>
>>
>>
>> In this version, I have addressed Alan’s most recent feedback.
>>
>>
>>
>> Please let me know if you have any further feedback and comments.
>>
>>
>>
>> Thanks,
>>
>> Lucy
>>
>>
>>
>> From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
>> Sent: Thursday, September 14, 2017 1:17 PM
>> To: Lu, Yingqi <yingqi.lu at intel.com>
>> Cc: Alan Bateman <Alan.Bateman at oracle.com>; nio-dev at openjdk.java.net
>> Subject: Re: Proposal for adding O_DIRECT support into JDK 9
>>
>>
>>
>> Hi Lucy,
>>
>>
>>
>> It would be awkward to add another parameter to the IOUtil methods
>> just to be able to move this check down a level. I do not see anything
>> wrong with leaving it as is.
>>
>>
>>
>> Thanks,
>>
>>
>>
>> Brian
>>
>>
>>
>> On Sep 14, 2017, at 10:20 AM, Lu, Yingqi <yingqi.lu at intel.com> wrote:
>>
>>
>>
>> After taking another look at the code, I could not find an easy way to
>> check the channel/file position inside IOUtil class for non-positional
>> read/write (position is not provided as a parameter to FileChannel.read/write).
>>
>>
>>
>> Do you think it is proper to just leave the channel position check
>> inside FileChannelImpl like it is now?
>>
>>