Proposal for adding O_DIRECT support into JDK 9

[Lu, Yingqi]

Thank you! I will use the tool for the future versions.

Thanks,
Lucy

From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Wednesday, September 20, 2017 10:28 AM
To: Lu, Yingqi <yingqi.lu at intel.com>
Cc: nio-dev at openjdk.java.net
Subject: Re: Proposal for adding O_DIRECT support into JDK 9

Hi Lucy,

The jcheck Mercurial extension [1] indicates a trailing whitespace at line 468 of src/java.base/windows/native/libnio/ch/FileDispatcherImpl.c. No need to generate a new webrev for this alone but before the final version of the patch you might want to run jcheck and fix any problems using the Perl normalizer script [2].

Thanks,

Brian

[1] http://openjdk.java.net/projects/code-tools/jcheck/
[2] http://hg.openjdk.java.net/jdk10/jdk10/file/62306e615de1/make/scripts/normalizer.pl

On Sep 19, 2017, at 10:08 AM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:


Here is the updated version of the patch:http://cr.openjdk.java.net/~kkharbas/8164900/webrev.16/

In this version, I applied your clean-up fix.

Please let me know if there is anything missing.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170920/ba80bd3d/attachment.html>