8200583: (se) Selector clean-up, part 4

Chris Hegarty chris.hegarty at oracle.com
Thu Apr 5 12:28:38 UTC 2018


> On 5 Apr 2018, at 10:35, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> ...
> On 05/04/2018 01:15, Brian Burkhalter wrote:
>>    http://cr.openjdk.java.net/~alanb/8200583/webrev/index.html
...
>> ..Fixed now, and webrev refreshed in place, and I've re-run all the tests again.

It’s strange reviewing this issue, that is lower in your patch queue
than 8200458. I was just about to comment on the absence of 
translateAndUpdateReadyOps ;-)

DevPollSelectorImpl::doSelect should probably limit the timeout
to Integer.MAX_VALUE,
    long to = Math.min(timeout, Integer.MAX_VALUE); 

Not for now, but I wonder if implRegister could eventually be
removed?

Also, I noticed that the private ensureOpen() implementations
could eventually be removed if/when SlectorImpl made its
implementation available to subclasses.

Otherwise, looks good.

-Chris.








More information about the nio-dev mailing list