[12] 8193822: Remove unused newDirectByteBuffer and truncate methods from buffer classes

[Henry Jen]

I actually used this method in panama, is there a replacement? Line 194 at

http://hg.openjdk.java.net/panama/dev/file/d7a12ed2faf9/src/java.base/share/classes/java/foreign/memory/Pointer.java

Cheers,
Henry


> On Aug 8, 2018, at 8:43 AM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
> 
> +1
> Paul.
> 
>> On Aug 8, 2018, at 7:45 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8193822
>> 
>> Diff included below (excluding copyright year update).
>> 
>> Thanks,
>> 
>> Brian
>> 
>> --- a/src/java.base/share/classes/java/nio/Buffer.java
>> +++ b/src/java.base/share/classes/java/nio/Buffer.java
>> @@ -717,14 +717,6 @@
>>                  public JavaNioAccess.BufferPool getDirectBufferPool() {
>>                      return Bits.BUFFER_POOL;
>>                  }
>> -                @Override
>> -                public ByteBuffer newDirectByteBuffer(long addr, int cap, Object ob) {
>> -                    return new DirectByteBuffer(addr, cap, ob);
>> -                }
>> -                @Override
>> -                public void truncate(Buffer buf) {
>> -                    buf.truncate();
>> -                }
>>              });
>>      }
>>  
>> --- a/src/java.base/share/classes/jdk/internal/misc/JavaNioAccess.java
>> +++ b/src/java.base/share/classes/jdk/internal/misc/JavaNioAccess.java
>> @@ -39,18 +39,4 @@
>>          long getMemoryUsed();
>>      }
>>      BufferPool getDirectBufferPool();
>> -
>> -    /**
>> -     * Constructs a direct ByteBuffer referring to the block of memory starting
>> -     * at the given memory address and extending {@code cap} bytes.
>> -     * The {@code ob} parameter is an arbitrary object that is attached
>> -     * to the resulting buffer.
>> -     */
>> -    ByteBuffer newDirectByteBuffer(long addr, int cap, Object ob);
>> -
>> -    /**
>> -     * Truncates a buffer by changing its capacity to 0.
>> -     */
>> -    void truncate(Buffer buf);
>> -
>>  }
>> 
>