adding rsockets support into JDK

[Lu, Yingqi]

Hi Brian,

Thank you for the help!! Really nice to work with you again here :)

I will look into your comments and try to fix the issues. Together with changes following Alan's feedback, I will submit version 10 for review.

Thanks,
Lucy

From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Wednesday, August 29, 2018 2:38 PM
To: Lu, Yingqi <yingqi.lu at intel.com>
Cc: Alan Bateman <Alan.Bateman at oracle.com>; nio-dev at openjdk.java.net; Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; Aundhe, Shirish <shirish.aundhe at intel.com>; Kaczmarek, Eric <eric.kaczmarek at intel.com>
Subject: Re: adding rsockets support into JDK

Hi Lucy,

I am starting to try to pitch in a little bit to help review this huge patch.

Firstly, the current (.09) version of the patch fails to build in our test system with "ld: cannot find -lrdmacm" so  the dlopen/dlsym approach appears to be a necessity.

On a very minor note, the change to

src/java.base/share/classes/java/net/InetAddressContainer.java

appears to be the inadvertent deletion of a space before the declaration of 'addr' .

Thanks,

Brian

On Aug 29, 2018, at 9:35 AM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:


rdma/rsocket.h will be installed as part of librdmacm package. I found some examples of using dlopen/dlsym in current jdk code tree and I will try to study and follow. This is my first time doing this, I will let you know if I have questions (I am sure I will have :-)).

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180829/bb1eb12f/attachment-0001.html>