adding rsockets support into JDK
Lu, Yingqi
yingqi.lu at intel.com
Mon Dec 3 05:48:54 UTC 2018
Hi Alan,
Please find version 22 of the patch is available at http://cr.openjdk.java.net/~ylu/8195160.22
The updated Javadoc is available at http://cr.openjdk.java.net/~ylu/rsocket_docs/api/jdk.net/jdk/net/package-summary.html
Same Javadoc zip file has also been updated in the CSR at https://bugs.openjdk.java.net/browse/JDK-8205186
In this version, I have changed following items:
1. In the class description of RdmaSockets.java, I changed UOE to UnsupportedOperationException, in addition, I added the Javadoc link for openXXX methods
2. Made RdmaPollSelectorProvider directly extends SelectorProvider
3. Merged LinuxRdmaPollSelectorProvider with Linux version of RdmaPollSelectorProvider since they are both only available to Linux Platform
4. Similar to 3, I merged LinuxRdmaSocketDispatcher with RdmaSocketDispatcher
5. Removed os.name check in RdmaSocketImpl.java as well since the code is only available to Linux platform
Thanks,
Lucy
>-----Original Message-----
>From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
>Sent: Sunday, December 2, 2018 8:12 AM
>To: Lu, Yingqi <yingqi.lu at intel.com>
>Cc: Aundhe, Shirish <shirish.aundhe at intel.com>; Viswanathan, Sandhya
><sandhya.viswanathan at intel.com>; nio-dev at openjdk.java.net; Kaczmarek,
>Eric <eric.kaczmarek at intel.com>
>Subject: Re: adding rsockets support into JDK
>
>Lucy,
>
>I checked the CSR and it looks good but in the class description it has the
>wording that we discussed in mail:
>
>"The selector provider does not support datagram channels and pipes. The
>The openDatagramChannel and openPipe methods throw UOE."
>
>I assume you meant to change "UOE" to "UnsupportedOperationException",
>and I think we can link the openXXX methods to their javadoc.
>
>For the implementation then it looks like RmdaPollSelectorProvider extends
>SelectorProviderImpl without overriding these openXXX methods.
>This means it will create instances of DatagramChannelImpl and PipeImpl
>associated with the RDMA provider which isn't right. It might be simpler to just
>extend SelectorProvider and that will force you to override the abstract
>methods.
>
>While looking into that I see that the Linux version of
>RdmaPollSelectorProvider is still checking the value of os.name. It doesn't
>need to do that now and probably left over from an early iteration.
>
>-Alan
More information about the nio-dev
mailing list