adding rsockets support into JDK

[Lu, Yingqi]

Hi Brian,

Thank you for the quick check. I forgot to add RdmaSocketImpl.c into the original patch file.

The patch is updated at the same link: http://cr.openjdk.java.net/~ylu/8195160.23/. Please let me know if you see any issues with the updated version.

I also took a look at the wording changes you made at http://cr.openjdk.java.net/~bpb/8195160/webrev-22-delta/. They look pretty good to me:). Unless others have more feedback on the wording, I will incorporate exactly the changes into version 24.

Thanks,
Lucy

From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Monday, December 3, 2018 6:02 PM
To: Lu, Yingqi <yingqi.lu at intel.com>
Cc: Alan Bateman <Alan.Bateman at oracle.com>; Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; nio-dev at openjdk.java.net; Aundhe, Shirish <shirish.aundhe at intel.com>; Kaczmarek, Eric <eric.kaczmarek at intel.com>
Subject: Re: adding rsockets support into JDK

Hi Lucy,

I am seeing a build failure on Linux with this version:

workspace/build/linux-x64/support/native/jdk.net/libextnet/RdmaSocketInputStream.o:<http://jdk.net/libextnet/RdmaSocketInputStream.o:> In function `Java_jdk_internal_net_rdma_RdmaSocketInputStream_init':
workspace/open/src/jdk.net/linux/native/libextnet/RdmaSocketInputStream.c:40:<http://jdk.net/linux/native/libextnet/RdmaSocketInputStream.c:40:> undefined reference to `NET_GetFileDescriptorID'
workspace/build/linux-x64/support/native/jdk.net/libextnet/RdmaSocketOutputStream.o:<http://jdk.net/libextnet/RdmaSocketOutputStream.o:> In function `Java_jdk_internal_net_rdma_RdmaSocketOutputStream_init':
workspace/open/src/jdk.net/linux/native/libextnet/RdmaSocketOutputStream.c:42:<http://jdk.net/linux/native/libextnet/RdmaSocketOutputStream.c:42:> undefined reference to `NET_GetFileDescriptorID'
collect2: error: ld returned 1 exit status
Lib-jdk.net.gmk:32: recipe for target 'workspace/build/linux-x64/support/modules_libs/jdk.net/libextnet.so'<http://jdk.net/libextnet.so'> failed
make[3]: *** [workspace/build/linux-x64/support/modules_libs/jdk.net/libextnet.so<http://jdk.net/libextnet.so>] Error 1
make/Main.gmk:215: recipe for target 'jdk.net<http://jdk.net>-libs' failed


Thanks,


Brian


On Dec 3, 2018, at 5:25 PM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:

Here is the link to the version 23 of the patch: http://cr.openjdk.java.net/~ylu/8195160.23/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20181204/df9bd1d3/attachment.html>