RFR 8196535: Remove support for pre-Java 6 non-JVM-wide file locking
Brian Burkhalter
brian.burkhalter at oracle.com
Fri Feb 2 22:52:23 UTC 2018
Updated version
http://cr.openjdk.java.net/~bpb/8196535/webrev.01/
which includes all the changes suggested below except making the constructor private which is not done because the factory method is removed.
I could not locate any existing tests specific to the system property being removed.
Thanks,
Brian
On Feb 2, 2018, at 8:55 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> On Feb 2, 2018, at 3:15 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>
>> Good to see this going away. You can probably get rid of the static factory method (newFileLockTable) too if you also.
>
> Yeah I had thought of that but did not do it.
>
>> Also the methods implemented the now-deleted interface no longer need to be public.
>>
>> Minor nit, line break at FileChannel L1097 looks ugly so I assume you don't need that.
>
> Will make the above changes.
>
> On Feb 2, 2018, at 7:29 AM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
>
>> Nice cleanup.
>
> Thanks to Alan and Hamlin. I did not like the earlier versions either.
>
>> FileLockTable: line 80: typo "the a" -> "the"
>>
>> FileLockTable:89: the constructor should be private to avoid an end-run around the factory method.
>>
>> While editing FileLockTable.java perhaps convert imports to single imports instead of .*... your call.
>
> I did that in a prior version.
>
>> I'm assuming there were no tests for the old setting since there none in the review.
>
> I don’t think so but I will double check.
>
>> FileChannelImpl.java:1096: if the line doesn't need to be continued, maybe all on 1 line
>
>
> Will make the above changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180202/f334b103/attachment.html>
More information about the nio-dev
mailing list