RFR 8196908: (ch, fs) Safe publication of monitor objects and some others

[Brian Burkhalter]

Hi Pavel,

+1

Brian

On Feb 7, 2018, at 4:07 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 07/02/2018 11:29, Pavel Rappo wrote:
>> Hello,
>> 
>> Please review the following change:
>> 
>>  http://cr.openjdk.java.net/~prappo/8196908/webrev.00/
>> 
>> This change addresses a number of issues with safe publication and covers some
>> trivial typos. It seems that there are more similar issues in that area.
>> However, I believe it is better to be rather conservative and firstly address
>> issues that are pretty straightforward.
>> 
> This look good, the only thing to check is the new asserts in SelectorImpl.implRegister and whether they push the method size over an inlining threshold. As they are useful when changing this area then you could add them commented out if you want.


On Feb 7, 2018, at 4:33 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:

> Hi Pavel,
> 
> KQueueArrayWrapper.java: I think you can make is64bit final.
> 
> cheers,
> 
> -- daniel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180207/820c6eeb/attachment.html>