RFR 8191416: (bf) DirectByteBuffer extends MappedByteBuffer, confuses instanceof tests
Roger Riggs
Roger.Riggs at Oracle.com
Thu Feb 8 20:05:16 UTC 2018
+1
On 2/8/2018 2:44 PM, Brian Burkhalter wrote:
> On Feb 6, 2018, at 12:33 PM, Remi Forax <forax at univ-mlv.fr
> <mailto:forax at univ-mlv.fr>> wrote:
>
>>> Minor comment is that the other methods uses "mapping" in the name so
>>> maybe hasFileMapping might be better.
>>
>> or remove the method hasMappedFile and inline the body in all the
>> calling methods given it's now a simple == test.
>
> Updated patch with hasMappedFile() inlined:
>
> http://cr.openjdk.java.net/~bpb/8191416/webrev.01/
> <http://cr.openjdk.java.net/%7Ebpb/8191416/webrev.01/>
>
> Thanks,
>
> Brian
More information about the nio-dev
mailing list