RFR 8191416: (bf) DirectByteBuffer extends MappedByteBuffer, confuses instanceof tests

[forax at univ-mlv.fr]

Looks good. 

Rémi 

> De: "Brian Burkhalter" <brian.burkhalter at oracle.com>
> À: "Remi Forax" <forax at univ-mlv.fr>
> Cc: "Alan Bateman" <Alan.Bateman at oracle.com>, "nio-dev"
> <nio-dev at openjdk.java.net>
> Envoyé: Jeudi 8 Février 2018 20:44:36
> Objet: Re: RFR 8191416: (bf) DirectByteBuffer extends MappedByteBuffer, confuses
> instanceof tests

> On Feb 6, 2018, at 12:33 PM, Remi Forax < [ mailto:forax at univ-mlv.fr |
> forax at univ-mlv.fr ] > wrote:

>>> Minor comment is that the other methods uses "mapping" in the name so
>>> maybe hasFileMapping might be better.

>> or remove the method hasMappedFile and inline the body in all the calling
>> methods given it's now a simple == test.
> Updated patch with hasMappedFile() inlined:

> [ http://cr.openjdk.java.net/~bpb/8191416/webrev.01/ |
> http://cr.openjdk.java.net/~bpb/8191416/webrev.01/ ]

> Thanks,

> Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180209/13830d22/attachment.html>