8202252: (aio) Closed AsynchronousSocketChannel keeps completion handler alive
Alan Bateman
Alan.Bateman at oracle.com
Mon Jul 2 17:41:19 UTC 2018
On 02/07/2018 17:44, Brian Burkhalter wrote:
> :
>
> The test was emulating what the submitter was trying. I agree however
> that it is pointless and the handler alone can be tested. Here is an
> updated version without a ReferenceQueue:
>
> http://cr.openjdk.java.net/~bpb/8202252/webrev.02/
> <http://cr.openjdk.java.net/%7Ebpb/8202252/webrev.02/>
>
> The ugly thing about this version, if it matters, is that when run
> against the un-patched source the test just hangs instead of failing
> outright. I can look into the ReferenceQueue if need be.
>
This looks much better. Are you going to move the System.gc() into the
loop in waitForRefToClear? Also should the @require to exclude Windows
be dropped?
-Alan
More information about the nio-dev
mailing list