8202252: (aio) Closed AsynchronousSocketChannel keeps completion handler alive

[Alan Bateman]

On 03/07/2018 16:14, Brian Burkhalter wrote:
>
> On Jul 3, 2018, at 12:33 AM, Alan Bateman <Alan.Bateman at oracle.com 
> <mailto:Alan.Bateman at oracle.com>> wrote:
>
>> The bug may not have existed on Windows but I don't think we have 
>> other tests for this type of thing so my preference would be to drop 
>> the @requires os.family != "Windows".
>>
>> One thing to double check in the test is whether it closes all the 
>> connections. In testConnect it doesn't close the client connection 
>> and also it seems to forget to accept and close the other end too. It 
>> looks to be correct in testRead and testWrite but the line breaks 
>> make it hard to read - maybe you could have slightly longer lines 
>> here to make this easier to read.
>
> Here’s an updated version which hopefully addresses the foregoing 
> point successfully:
>
> http://cr.openjdk.java.net/~bpb/8202252/webrev.04/ 
> <http://cr.openjdk.java.net/%7Ebpb/8202252/webrev.04/>
>
I think this looks okay now.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180703/2e7253c4/attachment.html>