RFR of JDK-8202481: RegisterDuringSelect.java fails with java.util.concurrent.ExecutionException: java.nio.channels.ClosedSelectorException

Alan Bateman Alan.Bateman at oracle.com
Thu Jul 12 07:49:45 UTC 2018


On 12/07/2018 06:44, Hamlin Li wrote:
> Hi Alan,
>
> Thank you for review, I have updated code in place.
The additional arrive when ClosedSelectorException may confuse future 
maintainers of this test. I think the simplest thing is to just return 
null when ClosedSelectorException is thrown and that allows you to 
remove the isOpen check too.

There is also some left over traces in the patch. I assume they will be 
removed but if you are want to add additional traces then it would be 
good to keep it consistent with the existing messages.

-Alan.


More information about the nio-dev mailing list