8206448: (fs) Extended attributes assumed to be enabled on ext3 (lnx)

Alan Bateman Alan.Bateman at oracle.com
Fri Jul 13 08:02:51 UTC 2018



On 12/07/2018 23:20, Brian Burkhalter wrote:
> https://bugs.openjdk.java.net/browse/JDK-8206448
> http://cr.openjdk.java.net/~bpb/8206448/webrev.00/
>
> Modified
>
> 1) not to assume that extended attributes are enabled by default on ext3, and
> 2) to assume that they are enabled by default on ext4 if and only if the kernel version is greater than or equal to 2.6.39.
>
This mostly looks okay to me. It would be good to move getKernelVersion 
closer to the end of the source file as this area puts the fields at the 
top. We should probably clean up the xattrChecked/xattrEnabled handling 
at some point but what you have is fine. Also I assume we'll drop the 
kernel check at some point soon as 2.6.39 is really old and unlikely 
there will be any supported systems with these older kernels soon.

-Alan


More information about the nio-dev mailing list