RFR[12] of JDK-8207316, java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed

[Hamlin Li]

Hi Volker,

Thank you for comments.

In fact, on most of test machines its default timeout factor is not 1, 
for example, this issue is reported to occur on a machine with 
"JTREG_TIMEOUT_OPTION=-timeoutFactor:10".

Of course, your suggestion should work as well, lengthen timeout value 
will do no harm to tests, I just think it may not be necessary to have 
that long timeout value.
If you still think it's necessary to do it, I can modify as you suggested.

Thank you

-Hamlin


On 2018/7/19 3:17 PM, Volker Simonis wrote:
> Hi Hamlin,
>
> in general your change looks good, but isn't the default timeout
> factor "1" ? In that case your patch now effectively reduces the
> timeout for these tests if they are being run with the default
> configuration. Shouldn't your change use the current timeout values
> instead and make them subject to the timeout factor adjustment?
>
> Thank you and best regards,
> Volker
>
>
> On Thu, Jul 19, 2018 at 9:00 AM, Hamlin Li <huaming.li at oracle.com> wrote:
>> Would you please review the following patch?
>>
>> https://bugs.openjdk.java.net/browse/JDK-8207316
>>
>> http://cr.openjdk.java.net/~mli/8207316/webrev.00/
>>
>>
>> Thank you
>>
>> -Hamlin
>>