RFR[11] of JDK-8207244, java/nio/channels/Selector/SelectWithConsumer.java testInterruptDuringSelect() fails intermittently

Hamlin Li huaming.li at oracle.com
Thu Jul 19 07:47:13 UTC 2018


Hi Alan,

Thank you for review, I have updated in place: 
http://cr.openjdk.java.net/~mli/8207244/webrev.00/

-Hamlin


On 2018/7/19 3:29 PM, Alan Bateman wrote:
> On 19/07/2018 08:21, Alan Bateman wrote:
>> :
>>
>> For the issue, I think we should just the check for the upper bound, 
>> i.e. change the assert at L414 to just check that the duration is > 
>> 500ms. It doesn't matter if the select takes 6s or 30s on a really 
>> slow machine.
> A typo in my mail, I mean to say to drop the check for the upper 
> bound, this should do it:
>    assertTrue(duration > 500, "select did not block");
>
> -Alan
>
>



More information about the nio-dev mailing list