RFR[12] of JDK-8207316, java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed

Hamlin Li huaming.li at oracle.com
Thu Jul 19 07:57:00 UTC 2018


Hi Alan, Volker,

I have update the change in place: 
http://cr.openjdk.java.net/~mli/8207316/webrev.00/

Thank you

-Hamlin


On 2018/7/19 3:38 PM, Alan Bateman wrote:
>
> On 19/07/2018 08:17, Volker Simonis wrote:
>> Hi Hamlin,
>>
>> in general your change looks good, but isn't the default timeout
>> factor "1" ? In that case your patch now effectively reduces the
>> timeout for these tests if they are being run with the default
>> configuration. Shouldn't your change use the current timeout values
>> instead and make them subject to the timeout factor adjustment?
>>
> I agree the defaults shouldn't be reduced, they have been bumped 
> several times already to deal with really slow test machines.
>
> -Alan



More information about the nio-dev mailing list