8201407: Files.move throws DirectoryNonEmptyException when moving directory across file system

[Brian Burkhalter]

On May 25, 2018, at 7:05 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> On May 25, 2018, at 6:03 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
>> This version looks a lot better. I think the spec update is okay.
>> 
>> The implementation changes would be cleaner if we add an isEmptyDir method. Also in the Windows implementation would be easier to read if you specify the filter as `e -> true`.
> 
> I will look at the foregoing next week.

An updated version is here:

http://cr.openjdk.java.net/~bpb/8201407/webrev.02/

As ensureEmptyDir() method was added for each platform family. Note that the logic of this for UnixCopyFile has been updated especially at lines 381-393. This test passed on all platforms and further tests will be run.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180531/c47ec1e2/attachment.html>