[PATCH] 6350055: Atomic SelectionKey operations

[Philippe Marschall]

Hi

Sorry if I step out of line here, I'm just a lurker. Personally I'd like to see

@since 11

in the Javadoc.

Cheers
Philippe

On Thu, May 31, 2018 at 4:55 PM, David Lloyd <david.lloyd at redhat.com> wrote:
> And here [1] it is.
>
> [1] https://github.com/dmlloyd/openjdk/commit/atomic-nio-ops-v9
>
> On Thu, May 31, 2018 at 9:52 AM, David Lloyd <david.lloyd at redhat.com> wrote:
>> The testNioImplementation method covers IllegalArgumentException, but
>> I can add tests for CancelledKeyException easily...
>>
>> On Thu, May 31, 2018 at 7:25 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>>>
>>>
>>> On 30/05/2018 19:14, David Lloyd wrote:
>>>>
>>>> On Wed, May 23, 2018 at 9:00 AM, David Lloyd <david.lloyd at redhat.com>
>>>> wrote:
>>>>>
>>>>> I can probably add tests to show that the ops work.  I'm not so sure
>>>>> that I can make a test that proves the atomicity of the operation
>>>>> though.
>>>>
>>>> Updated with tests [1] & attached.
>>>>
>>> I quickly skimmed it and the test look reasonable. We should extend it to
>>> cover the CancelledKeyException and IllegaArgumentException cases too, I
>>> didn't spot anything testing these exceptions.
>>>
>>> -Alan
>>
>>
>>
>> --
>> - DML
>
>
>
> --
> - DML