[PATCH] 6350055: Atomic SelectionKey operations

[Alan Bateman]

On 06/06/2018 20:26, Brian Burkhalter wrote:
> On Jun 3, 2018, at 9:18 AM, Alan Bateman <Alan.Bateman at oracle.com 
> <mailto:Alan.Bateman at oracle.com>> wrote:
>
>> I've put a webrev with the updated patch here:
>> http://cr.openjdk.java.net/~alanb/6350055/webrev/index.html 
>> <http://cr.openjdk.java.net/%7Ealanb/6350055/webrev/index.html>
>
> Looks fine modulo three picayune items:
Thanks. The CSR [1] has been approved so I'll try to get this pushed on 
Thursday.

>
> 1) In SelectionKey I recommend putting a comma after “e.g.” at line 
> 245 and changing “rom” to “from” at line 246.
Okay.


>
> 2) In AtomicUpdates at line 179 I think the indentation is one space 
> too deep.
>
This is a try-with-resources with two resources. The second variable is 
just aligned with the first.

-Alan

[1] https://bugs.openjdk.java.net/browse/JDK-8204472
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180607/78aeb3e4/attachment.html>