adding rsockets support into JDK

Lu, Yingqi yingqi.lu at intel.com
Tue Jun 19 07:00:09 UTC 2018


Hi Alan,

Yes, help on Javadoc is definitely very much appreciated :-)
>>The CSR will need to include the javadoc for each of the methods. That isn't fully fleshed out in the webrev yet. Do you need help on this?

By the way, I found couple of other small issues in the code during testing and already fixed it. I am still working on the last couple test cases for socket options. Once I finish that, I will submit webrev version 6.

Thanks,
Lucy

>-----Original Message-----
>From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
>Sent: Monday, June 18, 2018 11:54 PM
>To: Lu, Yingqi <yingqi.lu at intel.com>; nio-dev at openjdk.java.net
>Cc: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; Aundhe, Shirish
><shirish.aundhe at intel.com>; Kaczmarek, Eric <eric.kaczmarek at intel.com>
>Subject: Re: adding rsockets support into JDK
>
>On 18/06/2018 22:19, Lu, Yingqi wrote:
>> Hi All,
>>
>> I just created a CSR at the meantime. The link is available at
>https://bugs.openjdk.java.net/browse/JDK-8205186.
>>
>> Please review this and let me know your feedback.
>>
>The CSR will need to include the javadoc for each of the methods. That isn't fully
>fleshed out in the webrev yet. Do you need help on this?
>
>The other thing is that adds a protected constructor to java.net.ServerSocket (to
>match the equivalent in java.net.Socket) so that will need to be included too. This
>addition means the scope changes to Java SE too.
>
>-Alan


More information about the nio-dev mailing list