8198372: API to create a SelectableChannel to a FileDescriptor

Brian Burkhalter brian.burkhalter at oracle.com
Wed Jun 20 19:28:35 UTC 2018


On Jun 20, 2018, at 7:30 AM, Chris Hegarty <chris.hegarty at oracle.com> wrote:

> > The webrev with the proposed API is here:
> >   http://cr.openjdk.java.net/~alanb/8198372/webrev/index.html
> 
> A few minor typos: "selected-kkey" "wth"
> 
> Otherwise, I think this quite good. It provides a low-level
> mechanism to inter-operate with other socket types on the
> system.

I concur. Just one minor comment:

Channels.java:

156:		Could this line be removed as a null fd would be detected implicitly at 158?

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180620/4532d9fc/attachment.html>


More information about the nio-dev mailing list